Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1531493

Re: net/sctp: vmalloc allocation failure in sctp_setsockopt/xt_alloc_table_info

Show all headers | View raw

On Mon, Nov 28, 2016 at 06:47:10PM +0100, Florian Westphal wrote:
> Neil Horman <nhorman@tuxdriver.com> wrote:
> > I'm not sure I agree with that.  Generally speaking it seems like the right
> > thing to do, if you want to avoid filling logs with warnings, but this is the
> > sort of error that is going to be accompanied by severe service interruption.
> > I'd rather see a reason behind that in the logs, than just have it occur
> > silently.
> 
> Its not silent -- the setsockopt call will fail and userspace should
> display an error.
> 
Thats not true.  If the OOM succedes in freeing enough memory to fulfill the
request the setsockopt may complete without error, you're just left with a
killed process...somewhere.  Thats seems a bit dodgy to me

Not saying it has to be a full stack trace, but some log annotation that shows
the oom killer got invoked seems called for here

Neil

> So I agree with Marcelo, lets suppress the oom spew here.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

net/sctp: vmalloc allocation failure in sctp_setsockopt/xt_alloc_table_info Andrey Konovalov <andreyknvl@google.com> - 2016-11-28 14:10 +0100
  Re: net/sctp: vmalloc allocation failure in  sctp_setsockopt/xt_alloc_table_info Neil Horman <nhorman@tuxdriver.com> - 2016-11-28 15:20 +0100
    Re: net/sctp: vmalloc allocation failure in sctp_setsockopt/xt_alloc_table_info Andrey Konovalov <andreyknvl@google.com> - 2016-11-28 15:40 +0100
      Re: net/sctp: vmalloc allocation failure in  sctp_setsockopt/xt_alloc_table_info Neil Horman <nhorman@tuxdriver.com> - 2016-11-28 15:50 +0100
        Re: net/sctp: vmalloc allocation failure in  sctp_setsockopt/xt_alloc_table_info Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2016-11-28 16:20 +0100
          Re: net/sctp: vmalloc allocation failure in  sctp_setsockopt/xt_alloc_table_info Neil Horman <nhorman@tuxdriver.com> - 2016-11-28 18:50 +0100
            Re: net/sctp: vmalloc allocation failure in  sctp_setsockopt/xt_alloc_table_info Florian Westphal <fw@strlen.de> - 2016-11-28 19:00 +0100
              Re: net/sctp: vmalloc allocation failure in  sctp_setsockopt/xt_alloc_table_info Neil Horman <nhorman@tuxdriver.com> - 2016-11-28 19:00 +0100
                Re: net/sctp: vmalloc allocation failure in  sctp_setsockopt/xt_alloc_table_info Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2016-11-28 19:20 +0100
                Re: net/sctp: vmalloc allocation failure in  sctp_setsockopt/xt_alloc_table_info Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2016-11-30 20:30 +0100
                [PATCH] netfilter: avoid warn and OOM on vmalloc call Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2016-11-30 20:50 +0100
                Re: [PATCH] netfilter: avoid warn and OOM on vmalloc call Andrey Konovalov <andreyknvl@google.com> - 2016-12-01 10:50 +0100
                Re: [PATCH] netfilter: avoid warn and OOM on vmalloc call Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2016-12-01 20:10 +0100
                Re: net/sctp: vmalloc allocation failure in  sctp_setsockopt/xt_alloc_table_info Florian Westphal <fw@strlen.de> - 2016-11-28 19:20 +0100
                Re: net/sctp: vmalloc allocation failure in  sctp_setsockopt/xt_alloc_table_info Eric Dumazet <eric.dumazet@gmail.com> - 2016-11-28 19:40 +0100

csiph-web