Re: [PATCH] proc: mm: export PTE sizes directly in smaps (v2)

From	Dave Hansen <dave@sr71.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] proc: mm: export PTE sizes directly in smaps (v2)
Date	2016-11-28 18:00 +0100
Message-ID	<sIxrA-4y6-29@gated-at.bofh.it> (permalink)
References	<sEiKt-1yN-11@gated-at.bofh.it> <sH3ce-3Wy-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/24/2016 06:22 AM, Vlastimil Babka wrote:
> On 11/17/2016 01:28 AM, Dave Hansen wrote:
>> @@ -702,11 +707,13 @@ static int smaps_hugetlb_range(pte_t *pt
>>      }
>>      if (page) {
>>          int mapcount = page_mapcount(page);
>> +        unsigned long hpage_size = huge_page_size(hstate_vma(vma));
>>
>> +        mss->rss_pud += hpage_size;
> 
> This hardcoded pud doesn't look right, doesn't the pmd/pud depend on
> hpage_size?

Urg, nope.  Thanks for noticing that!  I think we'll need something
along the lines of:

                if (hpage_size == PUD_SIZE)
                        mss->rss_pud += PUD_SIZE;
                else if (hpage_size == PMD_SIZE)
                        mss->rss_pmd += PMD_SIZE;

I'll respin and resend.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] proc: mm: export PTE sizes directly in smaps (v2) Dave Hansen <dave@sr71.net> - 2016-11-28 18:00 +0100
  Re: [PATCH] proc: mm: export PTE sizes directly in smaps (v2) Vlastimil Babka <vbabka@suse.cz> - 2016-11-28 22:10 +0100
    Re: [PATCH] proc: mm: export PTE sizes directly in smaps (v2) Dave Hansen <dave@sr71.net> - 2016-11-28 22:50 +0100
      Re: [PATCH] proc: mm: export PTE sizes directly in smaps (v2) Vlastimil Babka <vbabka@suse.cz> - 2016-11-29 09:10 +0100
      Re: [PATCH] proc: mm: export PTE sizes directly in smaps (v2) Catalin Marinas <catalin.marinas@arm.com> - 2016-11-29 16:20 +0100

csiph-web