Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1531404

Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 11/28/2016 02:17 PM, Andrew Lunn wrote:
>> I still wonder (and didn't get an answer back when I asked about this)
>> why a comment is preferred here. For other devices I know it's usual and
>> requested by the maintainers to use:
>>
>> 	compatible = "exact name", "earlyer device to match driver";
>>
>> . This is more robust, documents the situation more formally and makes
>> it better greppable. The price to pay is only a few bytes in the dtb
>> which IMO is ok.
> 
> We did discuss this a while back. The information is useless and
> should to be ignored if present.

Who is "we"?

> The switch has a register which contains its model and revision. Each
> port has a set of registers, and register 3 contains the
> model/version. For all devices compatible with the 6085, the port
> registers start at address 0x10. For the 6190, the port registers
> start at 0x0. So given one of these two compatible strings, we can
> find the model of the device, from something which is burned into the
> silicon.
> 
> Now, say we did add per device compatible strings. We look up the
> model burned into the silicon, find it is different to what the device
> tree is and do what? Fail the probe? Or just keep going using the

I'd say fail to probe is the right thing to do. Of course that doesn't
work for already supported models because it will break compatibility.

I'd value the advantages (i.e. easily find machines with a given
hardware) higher than making broken dtbs work, so being a bit silly is
fine for me.

> value in the silicon? It seems silly to fail the probe if the driver
> does support the model, but that means the device tree is never
> verified and hence probably wrong. Why have wrong information in the
> device tree, especially wrong information which we never use. It is
> better to not have that information in the device tree.

At least we'd have a canonical way to specify the type of switch. If
it's not verified it's as good and bad as a dts comment. But the latter
isn't available in the dtb, which I consider a small disadvantage.

Also it seems wrong to write "marvell,mv88e6085" (only) if I know the
hardware is really a "marvell,mv88e6176".

> Linus has said he does not like ARM devices because of all the busses
> which are not enumerable. Here we have a device which with a little
> bit of help we can enumerate. So we should. 

If you write

	compatible = "marvell,mv88e6176", "marvell,mv88e6085";

you can still enumerate in the same way as before.

There are several more instances where the device tree specifies
something that could be probed instead. Some examples:

	compatible = "ethernet-phy-id0141.0DD1", "ethernet-phy-ieee802.3-c22";
	compatible = "spansion,s25fl164k", "jedec,spi-nor";
	compatible = "fsl,imx25-flexcan", "fsl,p1010-flexcan";
	compatible = "arm,pl011", "arm,primecell";

So you think they are all doing it wrong?

Best regards
Uwe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] Documentation: net: dsa: marvell: Add 88E6176 Andreas Färber <afaerber@suse.de> - 2016-11-27 22:00 +0100
  [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support Andreas Färber <afaerber@suse.de> - 2016-11-27 22:00 +0100
    Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support Andrew Lunn <andrew@lunn.ch> - 2016-11-27 22:30 +0100
      Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support Andreas Färber <afaerber@suse.de> - 2016-11-27 23:00 +0100
        Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support Andrew Lunn <andrew@lunn.ch> - 2016-11-27 23:10 +0100
          Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support Andreas Färber <afaerber@suse.de> - 2016-11-27 23:50 +0100
            Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support Andrew Lunn <andrew@lunn.ch> - 2016-11-28 00:20 +0100
              Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support Uwe Kleine-König <uwe@kleine-koenig.org> - 2016-11-28 09:20 +0100
                Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support Andrew Lunn <andrew@lunn.ch> - 2016-11-28 14:20 +0100
                Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support Uwe Kleine-König <uwe@kleine-koenig.org> - 2016-11-28 16:50 +0100
                Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support Andrew Lunn <andrew@lunn.ch> - 2016-11-28 17:20 +0100
                Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-11-29 19:00 +0100
                Re: [PATCH 2/2] net: dsa: mv88e6xxx: Add 88E6176 device tree support Andrew Lunn <andrew@lunn.ch> - 2016-11-29 19:30 +0100

csiph-web