Re: [mdadm PATCH] Add failfast support.

From	Jes Sorensen <Jes.Sorensen@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [mdadm PATCH] Add failfast support.
Date	2016-11-28 15:00 +0100
Message-ID	<sIuDo-2Mu-29@gated-at.bofh.it> (permalink)
References	<sEJKG-2Hy-9@gated-at.bofh.it> <sGapr-1RE-9@gated-at.bofh.it> <sHc5P-1jS-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

NeilBrown <neilb@suse.com> writes:
> Allow per-device "failfast" flag to be set when creating an
> array or adding devices to an array.
>
> When re-adding a device which had the failfast flag, it can be removed
> using --nofailfast.
>
> failfast status is printed in --detail and --examine output.
>
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
>
> Hi Jes,
>  this patch adds mdadm support for the failfast functionality that
> Shaohua recently included in his for-next.
> Hopefully the man-page additions provide all necessary context.
> If there is anything that seems to be missing, I'll be very happy to
> add it.

Hi Neil,

It looks reasonable. The only minor concern I have is over the use of
hardcoded magic numbers like 'dv->failfast = 2' rather than using an
enum or defines with descriptive names. Something that can be addressed
later, so patch applied.

Cheers,
Jes

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [mdadm PATCH] Add failfast support. Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-11-28 15:00 +0100

csiph-web