Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1531234

Re: linux-next: build warning after merge of the wireless-drivers-next tree

Show all headers | View raw

Barry Day <briselec@gmail.com> writes:

> On Mon, Nov 28, 2016 at 09:25:30AM +0200, Kalle Valo wrote:
>> Stephen Rothwell <sfr@canb.auug.org.au> writes:
>> 
>> > Hi all,
>> >
>> > After merging the wireless-drivers-next tree, today's linux-next build
>> > (x86_64 allmodconfig) produced this warning:
>> >
>> > In file included from include/linux/usb/ch9.h:35:0,
>> >                  from include/linux/usb.h:5,
>> >                  from drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:32:
>> > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function 'rtl8xxxu_fill_txdesc_v2':
>> > include/linux/device.h:1214:36: warning: 'rate' may be used uninitialized in this function [-Wmaybe-uninitialized]
>> >  #define dev_info(dev, fmt, arg...) _dev_info(dev, fmt, ##arg)
>> >                                     ^
>> > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4841:6: note: 'rate' was declared here
>> >   u32 rate;
>> >       ^
>> >
>> > Introduced by commit
>> >
>> >   b4c3d9cfb607 ("rtl8xxxu: Pass tx_info to fill_txdesc in order to have access to retry count")
>> >
>> > This is a correct diagnosis.
>> 
>> Thanks for the report. Jes, can you send a patch to fix this? (Unless
>> someone else beats to it.)
>> 
>> -- 
>> Kalle Valo
>
> I posted a patch on the 26th that fixes this

Thanks, I see it:

https://patchwork.kernel.org/patch/9448225/

The commit log doesn't mention anything about the compilation warning,
I'll add that. Also a Fixes line is nice to have.

-- 
Kalle Valo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

linux-next: build warning after merge of the wireless-drivers-next  tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-11-28 02:00 +0100
  Re: linux-next: build warning after merge of the wireless-drivers-next tree Kalle Valo <kvalo@codeaurora.org> - 2016-11-28 08:30 +0100
    Re: linux-next: build warning after merge of the  wireless-drivers-next tree Barry Day <briselec@gmail.com> - 2016-11-28 09:30 +0100
      Re: linux-next: build warning after merge of the wireless-drivers-next tree Kalle Valo <kvalo@codeaurora.org> - 2016-11-28 12:50 +0100
        Re: linux-next: build warning after merge of the wireless-drivers-next tree Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-11-28 13:30 +0100

csiph-web