Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1531166
| From | Sebastian Andrzej Siewior <bigeasy@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 01/22] cpufreq/acpi-cpufreq: Convert to hotplug state machine |
| Date | 2016-11-28 10:50 +0100 |
| Message-ID | <sIqJs-lL-25@gated-at.bofh.it> (permalink) |
| References | <sHUqd-4EY-3@gated-at.bofh.it> <sHUqe-4EY-25@gated-at.bofh.it> <sImwa-66e-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2016-11-28 10:45:20 [+0530], Viresh Kumar wrote:
> > diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> > index 297e9128fe9f..2c29cbaca7b5 100644
> > --- a/drivers/cpufreq/acpi-cpufreq.c
> > +++ b/drivers/cpufreq/acpi-cpufreq.c
> > @@ -922,37 +909,47 @@ static struct cpufreq_driver acpi_cpufreq_driver = {
> > .attr = acpi_cpufreq_attr,
> > };
> >
> > +static enum cpuhp_state acpi_cpufreq_online;
> > +
> > static void __init acpi_cpufreq_boost_init(void)
> > {
> > - if (boot_cpu_has(X86_FEATURE_CPB) || boot_cpu_has(X86_FEATURE_IDA)) {
> > - msrs = msrs_alloc();
> > + int ret;
> >
> > - if (!msrs)
> > - return;
> > + if (!(boot_cpu_has(X86_FEATURE_CPB) || boot_cpu_has(X86_FEATURE_IDA)))
> > + return;
> >
> > - acpi_cpufreq_driver.set_boost = set_boost;
> > - acpi_cpufreq_driver.boost_enabled = boost_state(0);
> > + msrs = msrs_alloc();
> >
> > - cpu_notifier_register_begin();
> > + if (!msrs)
> > + return;
> >
> > - /* Force all MSRs to the same value */
> > - boost_set_msrs(acpi_cpufreq_driver.boost_enabled,
> > - cpu_online_mask);
>
> Why isn't this required anymore ?
Later there is cpuhp_setup_state() which invokes the online callback
(cpufreq_boost_online) which is doing this.
> > + acpi_cpufreq_driver.set_boost = set_boost;
> > + acpi_cpufreq_driver.boost_enabled = boost_state(0);
> >
> > - __register_cpu_notifier(&boost_nb);
> > -
> > - cpu_notifier_register_done();
> > + /*
> > + * This calls the online callback on all online cpu and forces all
> > + * MSRs to the same value.
> > + */
> > + ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "cpufreq/acpi:online",
> > + cpufreq_boost_online, cpufreq_boost_down_prep);
> > + if (ret < 0) {
> > + pr_err("acpi_cpufreq: failed to register hotplug callbacks\n");
> > + msrs_free(msrs);
>
> If 'msrs = NULL' is required to be done in the _exit() routine, then it should
> be done here as well. Right?
It is not required in the exit path, it is just needed here. It is gone
in the following patch anyway but I will post a fixed version.
> > + return;
> > }
> > + acpi_cpufreq_online = ret;
> > }
> >
> > static void acpi_cpufreq_boost_exit(void)
> > {
> > - if (msrs) {
> > - unregister_cpu_notifier(&boost_nb);
> > + if (!msrs)
> > + return;
> >
> > - msrs_free(msrs);
> > - msrs = NULL;
> > - }
> > + if (acpi_cpufreq_online >= 0)
> > + cpuhp_remove_state_nocalls(acpi_cpufreq_online);
> > +
> > + msrs_free(msrs);
> > + msrs = NULL;
> > }
> >
> > static int __init acpi_cpufreq_init(void)
> > --
> > 2.10.2
Sebastian
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
cpu hotplug: convert more drivers (batch #6 and last) Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-27 00:20 +0100
[PATCH 01/22] cpufreq/acpi-cpufreq: Convert to hotplug state machine Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-27 00:20 +0100
Re: [PATCH 01/22] cpufreq/acpi-cpufreq: Convert to hotplug state machine Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-28 06:20 +0100
Re: [PATCH 01/22] cpufreq/acpi-cpufreq: Convert to hotplug state machine Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-28 10:50 +0100
[PATCH 01/22 v2] cpufreq/acpi-cpufreq: Convert to hotplug state machine Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-28 11:00 +0100
Re: [PATCH 01/22 v2] cpufreq/acpi-cpufreq: Convert to hotplug state machine Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-28 11:00 +0100
Re: [PATCH 01/22 v2] cpufreq/acpi-cpufreq: Convert to hotplug state machine "Rafael J. Wysocki" <rafael@kernel.org> - 2016-11-28 13:50 +0100
[PATCH 13/22] iommu/vt-d: Convert to hotplug state machine Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-27 00:20 +0100
[tip:smp/hotplug] iommu/vt-d: Convert to hotplug state machine tip-bot for Anna-Maria Gleixner <tipbot@zytor.com> - 2016-12-02 01:20 +0100
[PATCH 11/22] mm/zswap: Convert dst-mem to hotplug state machine Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-27 00:20 +0100
[tip:smp/hotplug] mm/zswap: Convert dst-mem to hotplug state machine tip-bot for Sebastian Andrzej Siewior <tipbot@zytor.com> - 2016-12-02 01:20 +0100
[PATCH 19/22] soc/fsl/qbman: Convert to hotplug state machine Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-27 00:20 +0100
[tip:smp/hotplug] soc/fsl/qbman: Convert to hotplug state machine tip-bot for Sebastian Andrzej Siewior <tipbot@zytor.com> - 2016-12-02 01:20 +0100
[PATCH 04/22] idle/intel: Convert to hotplug state machine Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-27 00:20 +0100
Re: [PATCH 04/22] idle/intel: Convert to hotplug state machine Thomas Gleixner <tglx@linutronix.de> - 2016-11-28 18:40 +0100
Re: [PATCH 04/22] idle/intel: Convert to hotplug state machine Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-29 10:50 +0100
[PATCH 04/22 v2] idle/intel: Convert to hotplug state machine Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-29 11:00 +0100
[PATCH 07/22] mm/vmstat: Drop get_online_cpus() from init_cpu_node_state/vmstat_cpu_dead() Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-27 00:20 +0100
Re: [PATCH 07/22] mm/vmstat: Drop get_online_cpus() from init_cpu_node_state/vmstat_cpu_dead() Michal Hocko <mhocko@kernel.org> - 2016-11-28 10:30 +0100
[tip:smp/hotplug] mm/vmstat: Drop get_online_cpus() from init_cpu_node_state/vmstat_cpu_dead() tip-bot for Sebastian Andrzej Siewior <tipbot@zytor.com> - 2016-12-02 01:20 +0100
[PATCH 03/22] idle/intel: Remove superfluous SMP fuction call Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-27 00:20 +0100
[PATCH 06/22] tracing/rb: Convert to hotplug state machine Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-27 00:20 +0100
[tip:smp/hotplug] tracing/rb: Convert to hotplug state machine tip-bot for Sebastian Andrzej Siewior <tipbot@zytor.com> - 2016-12-02 01:20 +0100
[linux-next] tracing/rb: NULL pointer dereference at trace_rb_cpu_prepare() Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-12-07 12:20 +0100
[PATCH] tracing/rb: init the CPU mask on allocation Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-12-07 14:40 +0100
[tip:smp/hotplug] tracing/rb: Init the CPU mask on allocation tip-bot for Sebastian Andrzej Siewior <tipbot@zytor.com> - 2016-12-07 14:50 +0100
Re: [PATCH] tracing/rb: init the CPU mask on allocation Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-12-07 15:40 +0100
[PATCH 16/22] arm64/cpuinfo: Convert to hotplug state machine Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-27 00:20 +0100
Re: [PATCH 16/22] arm64/cpuinfo: Convert to hotplug state machine Suzuki K Poulose <suzuki.poulose@arm.com> - 2016-11-29 18:30 +0100
[tip:smp/hotplug] arm64/cpuinfo: Convert to hotplug state machine tip-bot for Anna-Maria Gleixner <tipbot@zytor.com> - 2016-12-02 01:20 +0100
[PATCH 22/22] Remove obsolete cpu hotplug register / unregister functions Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-27 00:20 +0100
[PATCH 18/22] zram: Convert to hotplug state machine Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2016-11-27 00:20 +0100
[tip:smp/hotplug] zram: Convert to hotplug state machine tip-bot for Anna-Maria Gleixner <tipbot@zytor.com> - 2016-12-02 01:20 +0100
csiph-web