Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1530932

Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: Add missing newline

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: Add missing newline
Date 2016-11-27 22:20 +0100
Message-ID <sIf1D-1fZ-11@gated-at.bofh.it> (permalink)
References <sIdMd-hC-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sun, Nov 27, 2016 at 08:54:44PM +0100, Andreas Färber wrote:
> Found while reviewing Marvell dsa bindings usage.

Hi Andreas

It is good practice to put the maintainer you expect to accept the
patch on the To: line. You have at least two different maintainers on
Cc: so it is currently ambiguous. And these lists can be high volume,
so without a copy in the maintainers inbox, patches can be overlooked.

> Fixes: f283745b3caf ("arm: vf610: zii devel b: Add support for switch interrupts")
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Andreas Färber <afaerber@suse.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew


> ---
>  arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> index 7ea617e47fe4..958b4c42d320 100644
> --- a/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-b.dts
> @@ -153,7 +153,8 @@
>  					switch0phy1: switch1phy0@1 {
>  						reg = <1>;
>  						interrupt-parent = <&switch0>;
> -						interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;					};
> +						interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
> +					};
>  					switch0phy2: switch1phy0@2 {
>  						reg = <2>;
>  						interrupt-parent = <&switch0>;
> -- 
> 2.6.6
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ARM: dts: vf610-zii-dev-rev-b: Add missing newline Andreas Färber <afaerber@suse.de> - 2016-11-27 21:00 +0100
  Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: Add missing newline Andrew Lunn <andrew@lunn.ch> - 2016-11-27 22:20 +0100
    Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: Add missing newline Andreas Färber <afaerber@suse.de> - 2016-11-27 22:40 +0100
      Re: [PATCH] ARM: dts: vf610-zii-dev-rev-b: Add missing newline Andrew Lunn <andrew@lunn.ch> - 2016-11-27 22:40 +0100

csiph-web