Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1532746

RE: [PATCH] perf/x86: fix event counter update issue

From "Liang, Kan" <kan.liang@intel.com>
Newsgroups linux.kernel
Subject RE: [PATCH] perf/x86: fix event counter update issue
Date 2016-11-29 21:40 +0100
Message-ID <sIXm1-4RO-3@gated-at.bofh.it> (permalink)
References (1 earlier) <sIMTD-6Co-23@gated-at.bofh.it> <sIUoa-311-45@gated-at.bofh.it> <sIUxQ-34p-11@gated-at.bofh.it> <sIVWW-451-23@gated-at.bofh.it> <sIWpY-4eA-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> On Tue, Nov 29, 2016 at 07:07:25PM +0000, Liang, Kan wrote:
> > > diff --git a/arch/x86/events/intel/core.c
> > > b/arch/x86/events/intel/core.c index a74a2dbc0180..cb8522290e6a
> > > 100644
> > > --- a/arch/x86/events/intel/core.c
> > > +++ b/arch/x86/events/intel/core.c
> > > @@ -4034,7 +4034,7 @@ __init int intel_pmu_init(void)
> > >
> > >  	/* Support full width counters using alternative MSR range */
> > >  	if (x86_pmu.intel_cap.full_width_write) {
> > > -		x86_pmu.max_period = x86_pmu.cntval_mask;
> > > +		x86_pmu.max_period = x86_pmu.cntval_mask >> 1;
> > >  		x86_pmu.perfctr = MSR_IA32_PMC0;
> > >  		pr_cont("full-width counters, ");
> > >  	}
> >
> > It doesn't work.
> > perf stat -x, -C1 -e cycles -- sudo taskset 0x2 ./loop 100000000000
> > 18446743727217821696,,cycles,313837854019,100.00
> >
> > delta 0xffffff8000001803 new 0x1804 prev 0xffffff8000000001
> >
> > I guess we need at least x86_pmu.cntval_mask >> 2 to prevent the sign
> > flag set.
> 
> Possible delta should be u64, as we know the counter cannot decrement.

Yes, the patch as below fixes the issue on my SLM.

diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c
index 6c3b0ef..abd97e8 100644
--- a/arch/x86/events/core.c
+++ b/arch/x86/events/core.c
@@ -69,7 +69,7 @@ u64 x86_perf_event_update(struct perf_event *event)
 	int shift = 64 - x86_pmu.cntval_bits;
 	u64 prev_raw_count, new_raw_count;
 	int idx = hwc->idx;
-	s64 delta;
+	u64 delta;
 
 	if (idx == INTEL_PMC_IDX_FIXED_BTS)
 		return 0;
diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
index a74a2db..cb85222 100644
--- a/arch/x86/events/intel/core.c
+++ b/arch/x86/events/intel/core.c
@@ -4034,7 +4034,7 @@ __init int intel_pmu_init(void)
 
 	/* Support full width counters using alternative MSR range */
 	if (x86_pmu.intel_cap.full_width_write) {
-		x86_pmu.max_period = x86_pmu.cntval_mask;
+		x86_pmu.max_period = x86_pmu.cntval_mask >> 1;
 		x86_pmu.perfctr = MSR_IA32_PMC0;
 		pr_cont("full-width counters, ");
 	}

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf/x86: fix event counter update issue kan.liang@intel.com - 2016-11-28 20:30 +0100
  Re: [PATCH] perf/x86: fix event counter update issue Stephane Eranian <eranian@google.com> - 2016-11-28 20:50 +0100
    RE: [PATCH] perf/x86: fix event counter update issue "Liang, Kan" <kan.liang@intel.com> - 2016-11-28 21:10 +0100
      Re: [PATCH] perf/x86: fix event counter update issue Stephane Eranian <eranian@google.com> - 2016-11-28 21:20 +0100
        RE: [PATCH] perf/x86: fix event counter update issue "Liang, Kan" <kan.liang@intel.com> - 2016-11-28 21:30 +0100
  Re: [PATCH] perf/x86: fix event counter update issue Peter Zijlstra <peterz@infradead.org> - 2016-11-29 10:30 +0100
    RE: [PATCH] perf/x86: fix event counter update issue "Liang, Kan" <kan.liang@intel.com> - 2016-11-29 15:50 +0100
      Re: [PATCH] perf/x86: fix event counter update issue Peter Zijlstra <peterz@infradead.org> - 2016-11-29 18:00 +0100
        RE: [PATCH] perf/x86: fix event counter update issue "Liang, Kan" <kan.liang@intel.com> - 2016-11-29 18:10 +0100
          Re: [PATCH] perf/x86: fix event counter update issue Peter Zijlstra <peterz@infradead.org> - 2016-11-29 18:20 +0100
    Re: [PATCH] perf/x86: fix event counter update issue Stephane Eranian <eranian@google.com> - 2016-11-29 18:30 +0100
      Re: [PATCH] perf/x86: fix event counter update issue Peter Zijlstra <peterz@infradead.org> - 2016-11-29 18:40 +0100
        Re: [PATCH] perf/x86: fix event counter update issue Stephane Eranian <eranian@google.com> - 2016-11-29 19:20 +0100
        Re: [PATCH] perf/x86: fix event counter update issue Andi Kleen <ak@linux.intel.com> - 2016-11-29 19:40 +0100
        RE: [PATCH] perf/x86: fix event counter update issue "Liang, Kan" <kan.liang@intel.com> - 2016-11-29 20:10 +0100
          Re: [PATCH] perf/x86: fix event counter update issue Peter Zijlstra <peterz@infradead.org> - 2016-11-29 20:40 +0100
            Re: [PATCH] perf/x86: fix event counter update issue Stephane Eranian <eranian@google.com> - 2016-11-29 21:40 +0100
            RE: [PATCH] perf/x86: fix event counter update issue "Liang, Kan" <kan.liang@intel.com> - 2016-11-29 21:40 +0100
              RE: [PATCH] perf/x86: fix event counter update issue "Odzioba, Lukasz" <lukasz.odzioba@intel.com> - 2016-12-02 14:00 +0100
                Re: [PATCH] perf/x86: fix event counter update issue Peter Zijlstra <peterz@infradead.org> - 2016-12-05 11:30 +0100
                RE: [PATCH] perf/x86: fix event counter update issue "Odzioba, Lukasz" <lukasz.odzioba@intel.com> - 2016-12-05 12:30 +0100
      RE: [PATCH] perf/x86: fix event counter update issue "Odzioba, Lukasz" <lukasz.odzioba@intel.com> - 2016-11-29 20:10 +0100

csiph-web