Re: [tip:x86/urgent] x86/apic/uv: Silence a shift wrapping warning

From	Alex Thorlton <athorlton@sgi.com>
Newsgroups	linux.kernel
Subject	Re: [tip:x86/urgent] x86/apic/uv: Silence a shift wrapping warning
Date	2016-11-29 22:10 +0100
Message-ID	<sIXP4-5gZ-5@gated-at.bofh.it> (permalink)
References	<sGO3v-2iP-3@gated-at.bofh.it> <sGVHH-7nD-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Nov 23, 2016 at 10:25:48PM -0800, tip-bot for Dan Carpenter wrote:
> Commit-ID:  c4597fd756836a5fb7900f2091797ab564390ad0
> Gitweb:     http://git.kernel.org/tip/c4597fd756836a5fb7900f2091797ab564390ad0
> Author:     Dan Carpenter <dan.carpenter@oracle.com>
> AuthorDate: Thu, 24 Nov 2016 01:19:08 +0300
> Committer:  Ingo Molnar <mingo@kernel.org>
> CommitDate: Thu, 24 Nov 2016 06:01:05 +0100
> 
> x86/apic/uv: Silence a shift wrapping warning
> 
> 'm_io' is stored in 6 bits so it's a number in the 0-63 range.  Static
> analysis tools complain that 1 << 63 will wrap so I have changed it to
> 1ULL << m_io.
> 
> This code is over three years old so presumably the bug doesn't happen
> very frequently in real life or someone would have complained by now.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Alex Thorlton <athorlton@sgi.com>

Acked-by: Alex Thorlton <athorlton@sgi.com>

- Alex

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [tip:x86/urgent] x86/apic/uv: Silence a shift wrapping warning Alex Thorlton <athorlton@sgi.com> - 2016-11-29 22:10 +0100

csiph-web