Re: [PATCH] drivers/base: use READ_ONCE instead of deprecated ACCESS_ONCE

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers/base: use READ_ONCE instead of deprecated ACCESS_ONCE
Date	2016-11-29 20:30 +0100
Message-ID	<sIWgh-4bp-11@gated-at.bofh.it> (permalink)
References	<sFjXP-OR-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Nov 19, 2016 at 11:52:48AM -0800, Davidlohr Bueso wrote:
> With the new standardized functions, we can replace all ACCESS_ONCE()
> calls across relevant drivers/base/.
> 
> ACCESS_ONCE() does not work reliably on non-scalar types. For example
> gcc 4.6 and 4.7 might remove the volatile tag for such accesses during
> the SRA (scalar replacement of aggregates) step:
> 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145
> 
> Update the new calls regardless of if it is a scalar type, this is
> cleaner than having three alternatives.
> 
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>

From does not match signed-off-by, so I can't take this, sorry.

greg k-h

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] drivers/base: use READ_ONCE instead of deprecated  ACCESS_ONCE Greg KH <gregkh@linuxfoundation.org> - 2016-11-29 20:30 +0100
  [PATCH v2] drivers/base: use READ_ONCE instead of deprecated  ACCESS_ONCE Davidlohr Bueso <dave@stgolabs.net> - 2016-11-30 15:00 +0100
    Re: [PATCH v2] drivers/base: use READ_ONCE instead of deprecated  ACCESS_ONCE Greg KH <gregkh@linuxfoundation.org> - 2016-11-30 15:00 +0100
      Re: [PATCH v2] drivers/base: use READ_ONCE instead of deprecated  ACCESS_ONCE Davidlohr Bueso <dave@stgolabs.net> - 2016-11-30 18:10 +0100
        Re: [PATCH v2] drivers/base: use READ_ONCE instead of deprecated  ACCESS_ONCE Greg KH <gregkh@linuxfoundation.org> - 2016-12-01 08:50 +0100

csiph-web