Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1532632
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3] kvm: svm: Use the hardware provided GPA instead of page walk |
| Date | 2016-11-29 19:30 +0100 |
| Message-ID | <sIVke-3Ce-1@gated-at.bofh.it> (permalink) |
| References | <sIVax-3yV-7@gated-at.bofh.it> <sIVax-3yV-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 29 Nov 2016, Brijesh Singh wrote:
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -5483,3 +5483,11 @@ void emulator_writeback_register_cache(struct x86_emulate_ctxt *ctxt)
> {
> writeback_registers(ctxt);
> }
> +
> +bool emulator_is_string_op(struct x86_emulate_ctxt *ctxt)
> +{
> + if (ctxt->d & String)
> + return true;
> +
> + return false;
> +}
Do we really need a full function call for this simple thing? Just because
this horrible CamelCase constant is in emulate.c?
What's wrong with moving that thing into a header and make it a trivial
inline:
#define INS_STRING (1 << 13)
static inline bool emulator_is_string_op(struct x86_emulate_ctxt *ctxt)
{
return ctxt->d & INS_STRING;
}
Hmm?
tglx
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH v3] kvm: svm: Use the hardware provided GPA instead of page walk Thomas Gleixner <tglx@linutronix.de> - 2016-11-29 19:30 +0100 Re: [PATCH v3] kvm: svm: Use the hardware provided GPA instead of page walk Paolo Bonzini <pbonzini@redhat.com> - 2016-12-08 16:00 +0100
csiph-web