Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1532466
| From | Marc MERLIN <marc@merlins.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free |
| Date | 2016-11-29 17:20 +0100 |
| Message-ID | <sITiq-2kT-23@gated-at.bofh.it> (permalink) |
| References | (3 earlier) <sGlNT-Wt-1@gated-at.bofh.it> <sGlXA-18B-43@gated-at.bofh.it> <sGp57-32O-11@gated-at.bofh.it> <sGznQ-1kN-27@gated-at.bofh.it> <sIoxX-7ud-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Nov 28, 2016 at 08:23:15AM +0100, Michal Hocko wrote:
> Marc, could you try this patch please? I think it should be pretty clear
> it should help you but running it through your use case would be more
> than welcome before I ask Greg to take this to the 4.8 stable tree.
>
> Thanks!
>
> On Wed 23-11-16 07:34:10, Michal Hocko wrote:
> [...]
> > commit b2ccdcb731b666aa28f86483656c39c5e53828c7
> > Author: Michal Hocko <mhocko@suse.com>
> > Date: Wed Nov 23 07:26:30 2016 +0100
> >
> > mm, oom: stop pre-mature high-order OOM killer invocations
> >
> > 31e49bfda184 ("mm, oom: protect !costly allocations some more for
> > !CONFIG_COMPACTION") was an attempt to reduce chances of pre-mature OOM
> > killer invocation for high order requests. It seemed to work for most
> > users just fine but it is far from bullet proof and obviously not
> > sufficient for Marc who has reported pre-mature OOM killer invocations
> > with 4.8 based kernels. 4.9 will all the compaction improvements seems
> > to be behaving much better but that would be too intrusive to backport
> > to 4.8 stable kernels. Instead this patch simply never declares OOM for
> > !costly high order requests. We rely on order-0 requests to do that in
> > case we are really out of memory. Order-0 requests are much more common
> > and so a risk of a livelock without any way forward is highly unlikely.
> >
> > Reported-by: Marc MERLIN <marc@merlins.org>
> > Signed-off-by: Michal Hocko <mhocko@suse.com>
Tested-by: Marc MERLIN <marc@merlins.org>
Marc
> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > index a2214c64ed3c..7401e996009a 100644
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -3161,6 +3161,16 @@ should_compact_retry(struct alloc_context *ac, unsigned int order, int alloc_fla
> > if (!order || order > PAGE_ALLOC_COSTLY_ORDER)
> > return false;
> >
> > +#ifdef CONFIG_COMPACTION
> > + /*
> > + * This is a gross workaround to compensate a lack of reliable compaction
> > + * operation. We cannot simply go OOM with the current state of the compaction
> > + * code because this can lead to pre mature OOM declaration.
> > + */
> > + if (order <= PAGE_ALLOC_COSTLY_ORDER)
> > + return true;
> > +#endif
> > +
> > /*
> > * There are setups with compaction disabled which would prefer to loop
> > * inside the allocator rather than hit the oom killer prematurely.
> > --
> > Michal Hocko
> > SUSE Labs
>
> --
> Michal Hocko
> SUSE Labs
>
--
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
.... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/ | PGP 1024R/763BE901
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Michal Hocko <mhocko@kernel.org> - 2016-11-28 08:30 +0100
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Marc MERLIN <marc@merlins.org> - 2016-11-28 22:00 +0100
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Marc MERLIN <marc@merlins.org> - 2016-11-29 17:00 +0100
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Michal Hocko <mhocko@kernel.org> - 2016-11-29 17:10 +0100
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Marc MERLIN <marc@merlins.org> - 2016-11-29 17:40 +0100
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 18:10 +0100
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Marc MERLIN <marc@merlins.org> - 2016-11-29 18:50 +0100
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-29 19:10 +0100
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Marc MERLIN <marc@merlins.org> - 2016-11-30 18:50 +0100
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-30 19:20 +0100
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Marc MERLIN <marc@merlins.org> - 2016-11-30 19:30 +0100
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Tejun Heo <tj@kernel.org> - 2016-11-30 21:40 +0100
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Kent Overstreet <kent.overstreet@gmail.com> - 2016-12-01 15:00 +0100
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-01 19:20 +0100
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Linus Torvalds <torvalds@linux-foundation.org> - 2016-12-01 19:40 +0100
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Marc MERLIN <marc@merlins.org> - 2016-11-30 00:10 +0100
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> - 2016-11-30 15:00 +0100
Re: 4.8.8 kernel trigger OOM killer repeatedly when I have lots of RAM that should be free Marc MERLIN <marc@merlins.org> - 2016-11-29 17:20 +0100
csiph-web