Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1532500

Re: [PATCH 2/2] ARM: omap: timers: reduce rating of gp_timer clocksource

Show all headers | View raw

On 11/24/2016 12:19 AM, Keerthy wrote:
> From: Grygorii Strashko <grygorii.strashko@ti.com>
>
> Now ARM Global timer (rating 300) will not be selected as clocksource,
> because it's initialized after OMAP GP Timer (rating 300) and
> Timekeeping core will not allow to replace clocksource with new one if
> both of them have the same rating.
>
> Reduce rating of OMAP GP Timer (300->290) when it's used as
> clocksource device - this will allow to select ARM Global timer (300)
> as clocksource when enabled.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> Signed-off-by: Keerthy <j-keerthy@ti.com>

Unfortunately, this patch has dependency [1] and can't be used alone as
it will cause ARM Global timer to be selected as clocksource
always on am437x and this will kill cpuidle, because ARM Global timer
is not in always_on domain.

The intention of enabling ARM Global timer is only for non-pm aware use
cases for RT-kernel latency improvement - where deep cpuidle states are 
not enabled.

[1] https://patchwork.kernel.org/patch/8940051/

> ---
>  arch/arm/mach-omap2/timer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
> index b2f2448..a0dbb0b 100644
> --- a/arch/arm/mach-omap2/timer.c
> +++ b/arch/arm/mach-omap2/timer.c
> @@ -376,7 +376,7 @@ static cycle_t clocksource_read_cycles(struct clocksource *cs)
>  }
>
>  static struct clocksource clocksource_gpt = {
> -	.rating		= 300,
> +	.rating		= 290,
>  	.read		= clocksource_read_cycles,
>  	.mask		= CLOCKSOURCE_MASK(32),
>  	.flags		= CLOCK_SOURCE_IS_CONTINUOUS,
>

-- 
regards,
-grygorii

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] ARM: omap: timers: reduce rating of gp_timer  clocksource Grygorii Strashko <grygorii.strashko@ti.com> - 2016-11-29 17:50 +0100
  Re: [PATCH 2/2] ARM: omap: timers: reduce rating of gp_timer  clocksource Tony Lindgren <tony@atomide.com> - 2016-12-02 18:10 +0100
    Re: [PATCH 2/2] ARM: omap: timers: reduce rating of gp_timer  clocksource Tony Lindgren <tony@atomide.com> - 2016-12-02 19:40 +0100
      Re: [PATCH 2/2] ARM: omap: timers: reduce rating of gp_timer  clocksource Keerthy <j-keerthy@ti.com> - 2016-12-05 05:20 +0100
    Re: [PATCH 2/2] ARM: omap: timers: reduce rating of gp_timer  clocksource Grygorii Strashko <grygorii.strashko@ti.com> - 2016-12-02 21:10 +0100

csiph-web