Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1532497

[PATCH 9/9] coresight: perf: Add a missing call to etm_free_aux

From Mathieu Poirier <mathieu.poirier@linaro.org>
Newsgroups linux.kernel
Subject [PATCH 9/9] coresight: perf: Add a missing call to etm_free_aux
Date 2016-11-29 17:50 +0100
Message-ID <sITLs-2xM-33@gated-at.bofh.it> (permalink)
References <sITLr-2xM-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Quentin Lambert <lambert.quentin@gmail.com>

Most error branches following the call to alloc_event_data contain a call
to etm_free_aux. This patch add a call to etm_free_aux to an error branch
that does not call it.

This issue was found with Hector.

Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
 drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
index 5a346fc8ce06..17741969026e 100644
--- a/drivers/hwtracing/coresight/coresight-etm-perf.c
+++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
@@ -215,7 +215,7 @@ static void *etm_setup_aux(int event_cpu, void **pages,
 	 */
 	sink = coresight_get_enabled_sink(true);
 	if (!sink)
-		return NULL;
+		goto err;
 
 	INIT_WORK(&event_data->work, free_event_data);
 
-- 
2.7.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/9] coresight: next v4.9-rc7  Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-11-29 17:50 +0100
  [PATCH 4/9] coresight: reset "enable_sink" flag when need be Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-11-29 17:50 +0100
  [PATCH 9/9] coresight: perf: Add a missing call to etm_free_aux Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-11-29 17:50 +0100
  [PATCH 5/9] coresight: tmc: Cleanup operation mode handling Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-11-29 17:50 +0100
  [PATCH 6/9] coresight: tmc: Get rid of mode parameter for helper routines Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-11-29 17:50 +0100
  [PATCH 2/9] coresight: etm3x: indentation fix (extra space removed) Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-11-29 17:50 +0100
  [PATCH 1/9] coresight: stm: return error code instead of zero in .packet() Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-11-29 17:50 +0100
  [PATCH 7/9] coresight: tmc: Remove duplicate memset Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-11-29 17:50 +0100
  [PATCH 8/9] coresight: Add support for ARM Coresight STM-500 Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-11-29 17:50 +0100
  [PATCH 3/9] coresight: etm3x: Adding missing features of Coresight PTM components Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-11-29 18:00 +0100
  Re: [PATCH 0/9] coresight: next v4.9-rc7 Greg KH <gregkh@linuxfoundation.org> - 2016-11-29 20:10 +0100

csiph-web