Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1532405
| From | Tin Huynh <tnhuynh@apm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V5] i2c: mux: pca954x: Add ACPI support for pca954x |
| Date | 2016-11-29 16:20 +0100 |
| Message-ID | <sISmm-1He-15@gated-at.bofh.it> (permalink) |
| References | <sING2-7bs-49@gated-at.bofh.it> <sISmm-1He-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Nov 29, 2016 at 5:15 PM, Peter Rosin <peda@axentia.se> wrote: > On 2016-11-29 11:12, Tin Huynh wrote: >> This patch enables ACPI support for mux-pca954x driver. > > Looks good, thanks! > >> Signed-off-by: Tin Huynh <tnhuynh@apm.com> > > Acked-by: Peter Rosin <peda@axentia.se> > > Cheers, > Peter > Added Mika However , in http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/gpio/gpio-pca953x.c?id=f32517bf1ae0a2de72b3f27200233bd3ad65bfeb log , i didn't see the CONFIG_ACPI and CONFIG_PTR. I have been acked with the same patch to support for i2c-leds ( without CONFIG_ACPI) About logic , if we don't enable CONFIG_ACPI , acpi_match_table will be NULL . So , the probe functions will be not called and nothing happens. I though we should use V3 (https://lkml.org/lkml/2016/11/28/893)
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V5] i2c: mux: pca954x: Add ACPI support for pca954x Tin Huynh <tnhuynh@apm.com> - 2016-11-29 11:20 +0100 Re: [PATCH V5] i2c: mux: pca954x: Add ACPI support for pca954x Tin Huynh <tnhuynh@apm.com> - 2016-11-29 16:20 +0100 Re: [PATCH V5] i2c: mux: pca954x: Add ACPI support for pca954x Wolfram Sang <wsa-dev@sang-engineering.com> - 2016-11-29 20:10 +0100
csiph-web