Re: [PATCH v2] platform/chrome: Use proper protocol transfer function

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] platform/chrome: Use proper protocol transfer function
Date	2016-11-29 13:30 +0100
Message-ID	<sIPHP-8re-5@gated-at.bofh.it> (permalink)
References	<sICrf-82A-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Brian,

On 11/28/2016 07:19 PM, Brian Norris wrote:
> From: Shawn Nematbakhsh <shawnn@chromium.org>
> 
> pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had
> one instance of these functions correct, but not the second, fall-back
> case. We use the fall-back only when the first command returns an
> IN_PROGRESS status, which is only used on some EC firmwares where we
> don't want to constantly poll the bus, but instead back off and
> sleep/retry for a little while.
> 

That's correct, sorry for missing this when pushing the patch to mainline.

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] platform/chrome: Use proper protocol transfer function Brian Norris <briannorris@chromium.org> - 2016-11-28 23:20 +0100
  Re: [PATCH v2] platform/chrome: Use proper protocol transfer function Javier Martinez Canillas <javier@osg.samsung.com> - 2016-11-29 13:30 +0100

csiph-web