Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1532035

Re: [PATCH v2] drm: tilcdc: fix parsing of some DT properties

Show all headers | View raw

On 11/28/16 13:37, Bartosz Golaszewski wrote:
> The DT binding for tildc is not consistent with the driver code: there
> are two options - 'max-width' and 'max-pixelclock' specified in the
> documentation which are parsed as 'ti,max-width' and
> 'ti'max-pixelclock' respectively.
> 
> Make the driver code consistent with the binding.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Reviewed-by: Jyri Sarha <jsarha@ti.com>

I'll pick this up for a pull request that I'll send shortly.

> ---
> v1 -> v2:
> - fix max-pixelclock too
> 
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 5efb369..bd0a3bd 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -296,12 +296,12 @@ static int tilcdc_init(struct drm_driver *ddrv, struct device *dev)
>  
>  	DBG("Maximum Bandwidth Value %d", priv->max_bandwidth);
>  
> -	if (of_property_read_u32(node, "ti,max-width", &priv->max_width))
> +	if (of_property_read_u32(node, "max-width", &priv->max_width))
>  		priv->max_width = TILCDC_DEFAULT_MAX_WIDTH;
>  
>  	DBG("Maximum Horizontal Pixel Width Value %dpixels", priv->max_width);
>  
> -	if (of_property_read_u32(node, "ti,max-pixelclock",
> +	if (of_property_read_u32(node, "max-pixelclock",
>  					&priv->max_pixelclock))
>  		priv->max_pixelclock = TILCDC_DEFAULT_MAX_PIXELCLOCK;
>  
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] drm: tilcdc: fix parsing of some DT properties Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-11-28 12:40 +0100
  Re: [PATCH v2] drm: tilcdc: fix parsing of some DT properties Jyri Sarha <jsarha@ti.com> - 2016-11-29 10:30 +0100

csiph-web