Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1531977
| From | Andrew Donnellan <andrew.donnellan@au1.ibm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] lockdep: fix report formatting |
| Date | 2016-11-29 09:00 +0100 |
| Message-ID | <sILuy-5oV-21@gated-at.bofh.it> (permalink) |
| References | <sIv6p-3fu-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 29/11/16 01:24, Dmitry Vyukov wrote:
> Since commit 4bcc595ccd80 ("printk: reinstate KERN_CONT for printing
> continuation lines") printk() requires KERN_CONT to continue log
> messages. Lots of printk() in lockdep.c and print_ip_sym() don't
> have it. As the result lockdep reports are completely messed.
>
> Add missing KERN_CONT and inline print_ip_sym() where necessary.
>
> Without this patch all scripts that parse kernel bug reports
> are broken. So it makes sense to get this into 4.9.
I'm glad someone else is looking at this, I started working on a similar
patch but haven't quite finished it :)
>
> Cc: aryabinin@virtuozzo.com
> Cc: andreyknvl@google.com
> Cc: joe@perches.com
> Cc: peterz@infradead.org
> Cc: mingo@redhat.com
> Cc: linux-kernel@vger.kernel.org
> Cc: syzkaller@googlegroups.com
Missing Signed-off-by.
FWIW I think the pr_cont() macro looks nicer than printk(KERN_CONT ...).
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] lockdep: fix report formatting Dmitry Vyukov <dvyukov@google.com> - 2016-11-28 15:30 +0100 Re: [PATCH] lockdep: fix report formatting Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-11-29 09:00 +0100 Re: [PATCH] lockdep: fix report formatting Ingo Molnar <mingo@kernel.org> - 2016-12-06 10:50 +0100 [tip:locking/urgent] lockdep: Fix report formatting tip-bot for Dmitry Vyukov <tipbot@zytor.com> - 2016-12-06 11:20 +0100
csiph-web