Groups > linux.kernel > #1531911

Re: [patch net] net: fec: cache statistics while device is down

From	Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Newsgroups	linux.kernel
Subject	Re: [patch net] net: fec: cache statistics while device is down
Date	2016-11-29 06:50 +0100
Message-ID	<sIJsJ-49m-3@gated-at.bofh.it> (permalink)
References	<sIv6q-3fu-25@gated-at.bofh.it> <sIFS9-1z0-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>  >
>  >+	fec_enet_update_ethtool_stats(ndev);
>  >+
> If user never open the interface, ethtool_stats[] always is 0 that are not expected.
> So, it also should be called at . fec_enet_init() ?

I don't think that zero stats is wrong for never-opened interface.

However a call at init path won't hurt, so I'll add it, just to clear
the question.

Nikita

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch net] net: fec: cache statistics while device is down Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2016-11-28 15:30 +0100
  RE: [patch net] net: fec: cache statistics while device is down Andy Duan <fugang.duan@nxp.com> - 2016-11-29 03:00 +0100
    Re: [patch net] net: fec: cache statistics while device is down Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2016-11-29 06:50 +0100

csiph-web