Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1531881

[PATCH V1] i2c: designware: fix wrong tx/rx fifo for ACPI

From Tin Huynh <tnhuynh@apm.com>
Newsgroups linux.kernel
Subject [PATCH V1] i2c: designware: fix wrong tx/rx fifo for ACPI
Date 2016-11-29 04:40 +0100
Message-ID <sIHqV-2QL-3@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


ACPI always sets txfifo and rxfifo to 32. This configuration will
cause problem if the IP core supports a fifo size of 16 bytes only.
Set the default value to 0 so the driver will get these parameters 
from IP core.

Signed-off-by: Tin Huynh <tnhuynh@apm.com>
---
 drivers/i2c/busses/i2c-designware-platdrv.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index 0b42a12..c88a4b8 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -97,8 +97,8 @@ static int dw_i2c_acpi_configure(struct platform_device *pdev)
 	const struct acpi_device_id *id;
 
 	dev->adapter.nr = -1;
-	dev->tx_fifo_depth = 32;
-	dev->rx_fifo_depth = 32;
+	dev->tx_fifo_depth = 0;
+	dev->rx_fifo_depth = 0;
 
 	/*
 	 * Try to get SDA hold time and *CNT values from an ACPI method if
-- 
1.7.1

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH V1] i2c: designware: fix wrong tx/rx fifo for ACPI Tin Huynh <tnhuynh@apm.com> - 2016-11-29 04:40 +0100
  Re: [PATCH V1] i2c: designware: fix wrong tx/rx fifo for ACPI Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-11-29 10:10 +0100
    Re: [PATCH V1] i2c: designware: fix wrong tx/rx fifo for ACPI Mika Westerberg <mika.westerberg@linux.intel.com> - 2016-11-29 10:30 +0100
      Re: [PATCH V1] i2c: designware: fix wrong tx/rx fifo for ACPI Tin Huynh <tnhuynh@apm.com> - 2016-11-29 10:40 +0100

csiph-web