Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1531791

Re: [PATCH v4 2/2] cpuidle: allow setting deepest idle

Show all headers | View raw

On Mon, Nov 28, 2016 at 10:33 PM, Jacob Pan
<jacob.jun.pan@linux.intel.com> wrote:
> When idle injection is used to cap power, we need to override
> governor's choice of idle states. This patch allows caller to select
> the deepest idle state on a CPU therefore achieve the maximum
> potential power saving.
>
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> ---
>  drivers/cpuidle/cpuidle.c | 11 +++++++++++
>  include/linux/cpuidle.h   |  4 +++-
>  kernel/sched/idle.c       | 13 ++++++++-----
>  3 files changed, 22 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index c73207a..887a52a 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -97,6 +97,17 @@ static int find_deepest_state(struct cpuidle_driver *drv,
>         return ret;
>  }
>
> +/* Set the current cpu to use the deepest idle state, override governors */
> +void cpuidle_use_deepest_state(bool enable)
> +{
> +       struct cpuidle_device *dev;
> +
> +       preempt_disable();
> +       dev = cpuidle_get_device();
> +       dev->use_deepest_state = enable;
> +       preempt_enable();
> +}
> +
>  #ifdef CONFIG_SUSPEND
>  /**
>   * cpuidle_find_deepest_state - Find the deepest available idle state.
> diff --git a/include/linux/cpuidle.h b/include/linux/cpuidle.h
> index bb31373..97c169b 100644
> --- a/include/linux/cpuidle.h
> +++ b/include/linux/cpuidle.h
> @@ -74,6 +74,7 @@ struct cpuidle_state {
>  struct cpuidle_device {
>         unsigned int            registered:1;
>         unsigned int            enabled:1;
> +       unsigned int            use_deepest_state:1;
>         unsigned int            cpu;
>
>         int                     last_residency;
> @@ -192,11 +193,12 @@ static inline struct cpuidle_driver *cpuidle_get_cpu_driver(
>  static inline struct cpuidle_device *cpuidle_get_device(void) {return NULL; }
>  #endif
>
> -#if defined(CONFIG_CPU_IDLE) && defined(CONFIG_SUSPEND)
> +#ifdef CONFIG_CPU_IDLE

The corresponding change in cpuidle.c is missing (and 0-day has just
found that too).

Thanks,
Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 2/2] cpuidle: allow setting deepest idle Jacob Pan <jacob.jun.pan@linux.intel.com> - 2016-11-28 22:40 +0100
  Re: [PATCH v4 2/2] cpuidle: allow setting deepest idle "Rafael J. Wysocki" <rafael@kernel.org> - 2016-11-29 00:20 +0100
  Re: [PATCH v4 2/2] cpuidle: allow setting deepest idle kbuild test robot <lkp@intel.com> - 2016-11-29 00:20 +0100
  Re: [PATCH v4 2/2] cpuidle: allow setting deepest idle kbuild test robot <lkp@intel.com> - 2016-11-29 02:10 +0100

csiph-web