Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1531765
| From | David Matlack <dmatlack@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/4] KVM: nVMX: support restore of VMX capability MSRs |
| Date | 2016-11-29 00:00 +0100 |
| Message-ID | <sID3X-8fY-7@gated-at.bofh.it> (permalink) |
| References | <sGuo9-6vC-5@gated-at.bofh.it> <sGuo9-6vC-17@gated-at.bofh.it> <sGEdQ-4jn-19@gated-at.bofh.it> <sIBvb-7oU-3@gated-at.bofh.it> <sICUh-8cJ-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Nov 28, 2016 at 2:48 PM, Paolo Bonzini <pbonzini@redhat.com> wrote: > On 28/11/2016 22:11, David Matlack wrote: >> > PINBASED_CTLS, PROCBASED_CTLS, EXIT_CTLS and ENTRY_CTLS can be derived >> > from their "true" counterparts, so I think it's better to remove the >> > "non-true" ones from struct nested_vmx (and/or add the "true" ones when >> > missing) and make them entirely computed. But it can be done on top. >> >> Good point. And that would mean userspace does not need to restore the >> non-true MSRs, right? > > Yes, sorry for being a bit too concise. :) I'll include this cleanup in the next version of the patchset since it affects which MSRs userspace will restore. It looks like a pretty simple patch. > >> KVM does not emulate MSR_IA32_VMX_BASIC[55]=0, >> and will probably never want to. > > That's a separate question, MSR_IA32_VMX_BASIC[55]=0 basically means > that the "true" capabilities are the same as the "default" capabilities. > If userspace wanted to set it that way, KVM right now would not hide > the "true" capability MSR, but on the other hand the nested hypervisor > should not even notice the difference. KVM would also need to use the non-true MSR in place of the true MSRs when checking VMCS12 during VM-entry. > > Paolo
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 1/4] KVM: nVMX: support restore of VMX capability MSRs David Matlack <dmatlack@google.com> - 2016-11-28 22:20 +0100
Re: [PATCH 1/4] KVM: nVMX: support restore of VMX capability MSRs Paolo Bonzini <pbonzini@redhat.com> - 2016-11-28 23:50 +0100
Re: [PATCH 1/4] KVM: nVMX: support restore of VMX capability MSRs David Matlack <dmatlack@google.com> - 2016-11-29 00:00 +0100
Re: [PATCH 1/4] KVM: nVMX: support restore of VMX capability MSRs Paolo Bonzini <pbonzini@redhat.com> - 2016-11-29 09:10 +0100
Re: [PATCH 1/4] KVM: nVMX: support restore of VMX capability MSRs David Matlack <dmatlack@google.com> - 2016-11-29 18:50 +0100
csiph-web