Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1531736

Re: [PATCH] dax: try to avoid unused function warnings

Show all headers | View raw

On Mon, Nov 28, 2016 at 1:24 PM, Ross Zwisler
<ross.zwisler@linux.intel.com> wrote:
> On Mon, Nov 28, 2016 at 10:12:17PM +0100, Arnd Bergmann wrote:
>> Without the get_block based I/O, we get warnings when CONFIG_FS_IOMAP
>> is disabled:
>>
>> fs/dax.c:736:12: error: ‘dax_insert_mapping’ defined but not used [-Werror=unused-function]
>> fs/dax.c:512:12: error: ‘copy_user_dax’ defined but not used [-Werror=unused-function]
>> fs/dax.c:490:12: error: ‘dax_load_hole’ defined but not used [-Werror=unused-function]
>> fs/dax.c:294:14: error: ‘grab_mapping_entry’ defined but not used [-Werror=unused-function]
>>
>> This patch blindly marks those as __maybe_unused, which avoids the warnings.
>> However, I suspect that there is actually more code in this file that should
>> not be provided without CONFIG_FS_IOMAP even though we don't get a warning
>> for it, and that we actually want a different rework, so please treat this
>> as a bug report. I have applied the patch locally in my randconfig build
>> setup to avoid seeing the warnings.
>>
>> Fixes: 5ac65736f740 ("dax: rip out get_block based IO support")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks for the report.  I think the right way to deal with this is to just
> select FS_IOMAP when we pull in the DAX code.  I sent out a patch last week
> that does this:
>
> https://lkml.org/lkml/2016/11/23/591

It seems awkward for both filesystems and the FS_DAX core to be
selecting FS_IOMAP.  In the end FS_DAX and FS_IOMAP are both libraries
of functionality that a filesystem can optionally use.  I think the
longer term FS_DAX stops being an independent user visible setting and
is instead selected by filesystems that want DAX.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] dax: try to avoid unused function warnings Arnd Bergmann <arnd@arndb.de> - 2016-11-28 22:20 +0100
  Re: [PATCH] dax: try to avoid unused function warnings Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-11-28 22:30 +0100
    Re: [PATCH] dax: try to avoid unused function warnings Dan Williams <dan.j.williams@intel.com> - 2016-11-28 23:20 +0100
      Re: [PATCH] dax: try to avoid unused function warnings Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-11-29 00:00 +0100
        Re: [PATCH] dax: try to avoid unused function warnings Dan Williams <dan.j.williams@intel.com> - 2016-11-29 00:10 +0100
          Re: [PATCH] dax: try to avoid unused function warnings Dave Chinner <david@fromorbit.com> - 2016-11-29 03:20 +0100

csiph-web