Re: [PATCH] cpuset: Remove unused 'struct cpuset*' variable

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cpuset: Remove unused 'struct cpuset*' variable
Date	2016-11-28 22:00 +0100
Message-ID	<sIBbP-72M-5@gated-at.bofh.it> (permalink)
References	(1 earlier) <sHgM9-4kp-3@gated-at.bofh.it> <sHhyx-4Tj-1@gated-at.bofh.it> <sHliO-7iy-21@gated-at.bofh.it> <sHzlL-7P7-3@gated-at.bofh.it> <sIoHD-7xl-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On Mon, Nov 28, 2016 at 08:37:09AM +0100, Michal Hocko wrote:
> I would disagree here. Randomly picking up fixes just because they are
> Fixing some commit is just too dangerous for the stable trees. Fixes tag
> should tell what was the culprit of the issue fixed by the patch,
> nothing more and nothing less.

Logically, I agree but then the only time I used the Fixes tag is when
I was tagging patches for stable and I can imagine people grepping for
the tag to backport.  Also, given that the offending commit is already
referenced in the description, the tag doesn't make much difference to
human beings.  I don't think it's a big deal either way but am more
inclined to follow Li's suggestion here given that he is maintaining
stable trees.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] cpuset: Remove unused 'struct cpuset*' variable Arnd Bergmann <arnd@arndb.de> - 2016-11-25 10:50 +0100
  Re: [PATCH] cpuset: Remove unused 'struct cpuset*' variable Zefan Li <lizefan@huawei.com> - 2016-11-26 01:50 +0100
    Re: [PATCH] cpuset: Remove unused 'struct cpuset*' variable Michal Hocko <mhocko@kernel.org> - 2016-11-28 08:40 +0100
      Re: [PATCH] cpuset: Remove unused 'struct cpuset*' variable Tejun Heo <tj@kernel.org> - 2016-11-28 22:00 +0100

csiph-web