[PATCH v3 19/33] btrfs: Fix race in btrfs_free_dummy_fs_info()

From	Matthew Wilcox <mawilcox@linuxonhyperv.com>
Newsgroups	linux.kernel
Subject	[PATCH v3 19/33] btrfs: Fix race in btrfs_free_dummy_fs_info()
Date	2016-11-28 21:10 +0100
Message-ID	<sIAps-6LC-9@gated-at.bofh.it> (permalink)
References	<sIAfL-6sT-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Matthew Wilcox <mawilcox@microsoft.com>

We drop the lock which protects the radix tree, so we must call
radix_tree_iter_next() in order to avoid a modification to the tree
invalidating the iterator state.

Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
---
 fs/btrfs/tests/btrfs-tests.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/btrfs/tests/btrfs-tests.c b/fs/btrfs/tests/btrfs-tests.c
index bf62ad9..73076a0 100644
--- a/fs/btrfs/tests/btrfs-tests.c
+++ b/fs/btrfs/tests/btrfs-tests.c
@@ -162,6 +162,7 @@ void btrfs_free_dummy_fs_info(struct btrfs_fs_info *fs_info)
 				slot = radix_tree_iter_retry(&iter);
 			continue;
 		}
+		slot = radix_tree_iter_next(&iter);
 		spin_unlock(&fs_info->buffer_lock);
 		free_extent_buffer_stale(eb);
 		spin_lock(&fs_info->buffer_lock);
-- 
2.10.2

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v3 19/33] btrfs: Fix race in btrfs_free_dummy_fs_info() Matthew Wilcox <mawilcox@linuxonhyperv.com> - 2016-11-28 21:10 +0100

csiph-web