Re: [PATCH 2/4] KVM: nVMX: fix checks on CR{0,4} during virtual VMX operation

From	David Matlack <dmatlack@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] KVM: nVMX: fix checks on CR{0,4} during virtual VMX operation
Date	2016-11-28 21:00 +0100
Message-ID	<sIAfM-6sT-23@gated-at.bofh.it> (permalink)
References	<sGuo9-6vC-5@gated-at.bofh.it> <sGuo9-6vC-19@gated-at.bofh.it> <sGE4a-4fv-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Nov 23, 2016 at 3:31 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 23/11/2016 02:14, David Matlack wrote:
>> +static bool fixed_bits_valid(u64 val, u64 fixed0, u64 fixed1)
>> +{
>> +     return ((val & fixed0) == fixed0) && ((~val & ~fixed1) == ~fixed1);
>> +}
>> +
>
> This is the same as vmx_control_verify (except with u64 arguments
> instead of u32).

Good point. I'll remove this duplication in v3.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/4] KVM: nVMX: fix checks on CR{0,4} during virtual VMX operation David Matlack <dmatlack@google.com> - 2016-11-28 21:00 +0100

csiph-web