Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1531560
| From | Jessica Yu <jeyu@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: module: fix DEBUG_SET_MODULE_RONX typo |
| Date | 2016-11-28 20:50 +0100 |
| Message-ID | <sIA66-6pe-5@gated-at.bofh.it> (permalink) |
| References | <sIvJ7-3HN-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
+++ Arnd Bergmann [28/11/16 15:59 +0100]:
>The newly added 'rodata_enabled' global variable is protected by
>the wrong #ifdef, leading to a link error when CONFIG_DEBUG_SET_MODULE_RONX
>is turned on:
>
>kernel/module.o: In function `disable_ro_nx':
>module.c:(.text.unlikely.disable_ro_nx+0x88): undefined reference to `rodata_enabled'
>kernel/module.o: In function `module_disable_ro':
>module.c:(.text.module_disable_ro+0x8c): undefined reference to `rodata_enabled'
>kernel/module.o: In function `module_enable_ro':
>module.c:(.text.module_enable_ro+0xb0): undefined reference to `rodata_enabled'
>
>CONFIG_SET_MODULE_RONX does not exist, so use the correct one instead.
>
>Fixes: 39290b389ea2 ("module: extend 'rodata=off' boot cmdline parameter to module mappings")
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks.
Jessica
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] module: fix DEBUG_SET_MODULE_RONX typo Arnd Bergmann <arnd@arndb.de> - 2016-11-28 16:10 +0100 Re: module: fix DEBUG_SET_MODULE_RONX typo Jessica Yu <jeyu@redhat.com> - 2016-11-28 20:50 +0100
csiph-web