Re: [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c

From	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c
Date	2016-11-25 20:50 +0100
Message-ID	<sHuFr-4La-5@gated-at.bofh.it> (permalink)
References	<sGJwX-7LD-11@gated-at.bofh.it> <sGJwX-7LD-9@gated-at.bofh.it> <sGM1I-ZJ-31@gated-at.bofh.it> <sH9rk-87w-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Nov 24, 2016 at 11:01:05PM +0200, Jarkko Sakkinen wrote:
> On Wed, Nov 23, 2016 at 12:38:30PM -0700, Jason Gunthorpe wrote:
> > On Wed, Nov 23, 2016 at 12:27:35PM -0500, Nayna Jain wrote:
> > > The device driver code for the event log has the init functions and
> > > TPM 1.2 parsing logic both defined in same file(tpm_eventlog.c).
> > > 
> > > Since the initialization functions are common with the TPM 2.0 event
> > > log support, this patch splits tpm_eventlog.c to have only TPM 1.2
> > > event log parsing logic and moves the init functions into
> > > tpm_eventlog_init.c.
> > 
> > I think I'd rather see a tpm_eventlog1.c/tpm_eventlog2.c than this
> > _init thing..
> 
> I would rather see tpm1-eventlog.c and tpm2-eventlog.c as we already
> have tpm2-cmd.c for the sake of consistency.

+1

Jason

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v5 1/3] tpm: move event log init functions to  tpm_eventlog_init.c Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-11-25 20:50 +0100

csiph-web