Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1530482

Re: [f2fs-dev] [PATCH 2/2] f2fs: allow dio read for LFS mode

Show all headers | View raw

On Fri, Nov 25, 2016 at 11:54:43PM +0800, Chao Yu wrote:
> On 2016/11/12 5:03, Jaegeuk Kim wrote:
> > We can allow dio reads for LFS mode, while doing buffered writes for dio writes.
> > 
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> >  fs/f2fs/data.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> > index ca53da5..996b9ae 100644
> > --- a/fs/f2fs/data.c
> > +++ b/fs/f2fs/data.c
> > @@ -1732,7 +1732,7 @@ static ssize_t f2fs_direct_IO(struct kiocb *iocb, struct iov_iter *iter)
> >  
> >  	if (f2fs_encrypted_inode(inode) && S_ISREG(inode->i_mode))
> >  		return 0;
> > -	if (test_opt(F2FS_I_SB(inode), LFS))
> > +	if (rw == WRITE && test_opt(F2FS_I_SB(inode), LFS))
> 
> For LFS mode, we must disallow any IPU in main area including direct write,
> instead of both direct read and write, so this patch relieves the restriction?

Yup.

> 
> IIUC, please add:
> 
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
> 
> Thanks,
> 
> >  		return 0;
> >  
> >  	trace_f2fs_direct_IO_enter(inode, offset, count, rw);
> > 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] f2fs: revert segment allocation for direct IO Jaegeuk Kim <jaegeuk@kernel.org> - 2016-11-11 22:10 +0100
  [PATCH 2/2] f2fs: allow dio read for LFS mode Jaegeuk Kim <jaegeuk@kernel.org> - 2016-11-11 22:10 +0100
    Re: [f2fs-dev] [PATCH 2/2] f2fs: allow dio read for LFS mode Chao Yu <chao@kernel.org> - 2016-11-25 17:00 +0100
      Re: [f2fs-dev] [PATCH 2/2] f2fs: allow dio read for LFS mode Jaegeuk Kim <jaegeuk@kernel.org> - 2016-11-25 19:20 +0100
  Re: [f2fs-dev] [PATCH 1/2] f2fs: revert segment allocation for direct  IO Chao Yu <chao@kernel.org> - 2016-11-25 17:10 +0100

csiph-web