Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1530349

Adding a .platform_init callback to sdhci_arasan_ops

Show all headers | View raw

Hi,

When using the Arasan SDHCI HW IP, there is a set of parameters called
"Hardware initialized registers"

(Table 7, Section "Pin Signals", page 56 of Arasan "SD3.0/SDIO3.0/eMMC4.4
AHB Host Controller", revision 6.0 document)

In some platforms those signals are connected to registers that need to
be programmed at some point for proper driver/HW initialisation.

I found that the 'struct sdhci_ops' contains a '.platform_init' callback
that is called from within 'sdhci_pltfm_init', and that seems a good
candidate for a place to program those registers (*).

Do you agree?

Best regards,

Sebastian


(*): This has been prototyped on 4.7 as working properly.
However, upstream commit:

commit 3ea4666e8d429223fbb39c1dccee7599ef7657d5
Author: Douglas Anderson <dianders@chromium.org>
Date:   Mon Jun 20 10:56:47 2016 -0700

    mmc: sdhci-of-arasan: Properly set corecfg_baseclkfreq on rk3399
...

could affect this solution because of the way the 'sdhci_arasan_of_match'
struct is used after that commit.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Adding a .platform_init callback to sdhci_arasan_ops Sebastian Frias <sf84@laposte.net> - 2016-11-25 16:30 +0100
  Re: Adding a .platform_init callback to sdhci_arasan_ops Adrian Hunter <adrian.hunter@intel.com> - 2016-11-28 11:40 +0100
    Re: Adding a .platform_init callback to sdhci_arasan_ops Sebastian Frias <sf84@laposte.net> - 2016-11-28 12:30 +0100
      Re: Adding a .platform_init callback to sdhci_arasan_ops Adrian Hunter <adrian.hunter@intel.com> - 2016-11-28 13:00 +0100
        Re: Adding a .platform_init callback to sdhci_arasan_ops Sebastian Frias <sf84@laposte.net> - 2016-11-28 14:30 +0100
          Re: Adding a .platform_init callback to sdhci_arasan_ops Sebastian Frias <sf84@laposte.net> - 2016-11-28 15:40 +0100
            Re: Adding a .platform_init callback to sdhci_arasan_ops Doug Anderson <dianders@chromium.org> - 2016-11-28 18:50 +0100
              Re: Adding a .platform_init callback to sdhci_arasan_ops Mason <slash.tmp@free.fr> - 2016-11-28 20:40 +0100
                Re: Adding a .platform_init callback to sdhci_arasan_ops Doug Anderson <dianders@chromium.org> - 2016-11-28 21:40 +0100
              Re: Adding a .platform_init callback to sdhci_arasan_ops Sebastian Frias <sf84@laposte.net> - 2016-12-05 13:30 +0100
                Re: Adding a .platform_init callback to sdhci_arasan_ops Doug Anderson <dianders@chromium.org> - 2016-12-05 17:20 +0100
          Re: Adding a .platform_init callback to sdhci_arasan_ops Doug Anderson <dianders@chromium.org> - 2016-11-28 19:10 +0100
            Re: Adding a .platform_init callback to sdhci_arasan_ops Sebastian Frias <sf84@laposte.net> - 2016-12-05 13:30 +0100
              Re: Adding a .platform_init callback to sdhci_arasan_ops Doug Anderson <dianders@chromium.org> - 2016-12-05 17:40 +0100
                Re: Adding a .platform_init callback to sdhci_arasan_ops Sebastian Frias <sf84@laposte.net> - 2016-12-06 14:50 +0100

csiph-web