Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1530827

Re: [git pull] vfs fix

Show all headers | View raw

On Sat, Nov 26, 2016 at 6:25 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> Two issues here.  One is that iov_iter_get_pages{,_alloc}() calling
> conventions are fucking ugly.

No arguments there. I was going to suggest adding an "int *npages"
argument and letting that function fill that in together with the page
array, but it's not like that is going to really make the interface
any prettier.

> Anyway, leaving that BUG_ON() had been wrong; I can send a followup
> massaging that thing as you've suggested, if you are interested in
> that.  But keep in mind that the whole iov_iter_get_pages...() calling
> conventions are going to be changed, hopefully soon.

If it indeed happens soon, I can certainly live with the existing code
as a temporary "ugly but it works". But if it ends up being post-4.10
I'd prefer to clean this up independently first, ok?

            Linus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[git pull] vfs fix Al Viro <viro@ZenIV.linux.org.uk> - 2016-11-27 02:20 +0100
  Re: [git pull] vfs fix Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-27 02:50 +0100
    Re: [git pull] vfs fix Al Viro <viro@ZenIV.linux.org.uk> - 2016-11-27 03:30 +0100
      Re: [git pull] vfs fix Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-27 04:00 +0100
      Re: [git pull] vfs fix Al Viro <viro@ZenIV.linux.org.uk> - 2016-11-27 04:00 +0100
        Re: [git pull] vfs fix Al Viro <viro@ZenIV.linux.org.uk> - 2016-11-27 04:10 +0100
        Re: [git pull] vfs fix "Yan, Zheng" <zyan@redhat.com> - 2016-11-28 10:00 +0100

csiph-web