Re: [PATCH] orangefs: Axe some dead code

From	Mike Marshall <hubcap@omnibond.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] orangefs: Axe some dead code
Date	2016-11-26 15:00 +0100
Message-ID	<sHLGh-7k9-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <sGluy-yw-23@gated-at.bofh.it> <sH1tL-2E0-5@gated-at.bofh.it> <sHwHf-63k-21@gated-at.bofh.it> <sHxMZ-70u-13@gated-at.bofh.it> <sHI5I-5bx-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

I think I understand what you're saying, except for this part:

> would have been secretly disapointed at your lack of
> courage in my heart but it would have been normal and fine.

I'm pretty sure that Linus won't accept a pull request from me
at the wrong time and that I won't send one at the wrong time
on purpose.

I've been laboring under the belief that the rc period is when
we "push only patches that do not include new functionalities",
and I would have thought that stripping out a few lines of dead
code would be appropriate then.

-Mike

On Sat, Nov 26, 2016 at 5:02 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Fri, Nov 25, 2016 at 06:09:39PM -0500, Mike Marshall wrote:
>> We're on rc7 now. Linus said in LWN that there might be a rc8 this time.
>> I'll try to get this pulled in 4.9-rc8 I hope, or sometime in 4.10...
>> it is just a
>> few lines of code that I don't think can be reached. Sorry for the confusion.
>
> It's not -rc material at all.  Especially not after -rc2.  If you had
> said 4.11, I would have been secretly disapointed at your lack of
> courage in my heart but it would have been normal and fine.  Merging
> this in 4.10 is the earliest reasonable.
>
> regards,
> dan carpenter
>

Thread

Re: [PATCH] orangefs: Axe some dead code Dan Carpenter <dan.carpenter@oracle.com> - 2016-11-25 23:00 +0100
  Re: [PATCH] orangefs: Axe some dead code Mike Marshall <hubcap@omnibond.com> - 2016-11-26 00:10 +0100
    Re: [PATCH] orangefs: Axe some dead code Dan Carpenter <dan.carpenter@oracle.com> - 2016-11-26 11:10 +0100
      Re: [PATCH] orangefs: Axe some dead code Mike Marshall <hubcap@omnibond.com> - 2016-11-26 15:00 +0100
        Re: [PATCH] orangefs: Axe some dead code Dan Carpenter <dan.carpenter@oracle.com> - 2016-11-28 12:10 +0100
          Re: [PATCH] orangefs: Axe some dead code Mike Marshall <hubcap@omnibond.com> - 2016-11-28 15:10 +0100
            Re: [PATCH] orangefs: Axe some dead code Dan Carpenter <dan.carpenter@oracle.com> - 2016-11-28 15:40 +0100

csiph-web