Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1530635

Re: [PATCH] staging: gdm724x: Align parameters to parenthesis

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] staging: gdm724x: Align parameters to parenthesis
Date 2016-11-26 09:30 +0100
Message-ID <sHGwW-45g-9@gated-at.bofh.it> (permalink)
References <sHvrP-5kG-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Nov 25, 2016 at 09:31:19PM +0100, Dawid Kurek wrote:
> Align parameters to open parenthesis. Also remove one blank line in
> sequence of two.

That's multiple things in the same patch, please break it up into
different patches (hint, if you say "Also" or "And" in a changelog
comment, that's a huge flag that it needs to be split.)

thanks,

greg k-h

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] staging: gdm724x: Align parameters to parenthesis Dawid Kurek <dawikur@gmail.com> - 2016-11-25 21:40 +0100
  Re: [PATCH] staging: gdm724x: Align parameters to parenthesis Greg KH <gregkh@linuxfoundation.org> - 2016-11-26 09:30 +0100

csiph-web