Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1529553

Re: [PATCH] clk: renesas: cpg_mstp: build for R8A774{3,5}

Show all headers | View raw

Hi Arnd,

On Thu, Nov 24, 2016 at 5:24 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> We get a link failure on R8A7745 and R8A7743 when the other platforms
> are disabled and nothing selects the clk-rcar-gen2 driver:
>
> drivers/clk/renesas/clk-rcar-gen2.o: In function `rcar_gen2_cpg_clocks_init':
> clk-rcar-gen2.c:(.init.text+0x39c): undefined reference to `cpg_mstp_add_clk_domain'

clk-rcar-gen2  is not used on R8A7745 and R8A7743?

> This adds another 'select' statement to get them to build as well.
>
> Fixes: 9127d54bb894 ("clk: renesas: cpg-mssr: Add R8A7745 support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/clk/renesas/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/renesas/Kconfig b/drivers/clk/renesas/Kconfig
> index 2586dfa0026b..4ebd9d3d24b7 100644
> --- a/drivers/clk/renesas/Kconfig
> +++ b/drivers/clk/renesas/Kconfig
> @@ -10,6 +10,8 @@ config CLK_RENESAS_CPG_MSTP
>         default y if ARCH_R7S72100
>         default y if ARCH_R8A73A4
>         default y if ARCH_R8A7740
> +       default y if ARCH_R8A7743
> +       default y if ARCH_R8A7745

R8A7745 and R8A7743 don't need the CPG_MSTP driver, they select
CLK_RENESAS_CPG_MSSR instead.

Perhaps you still have your patch "[PATCH] clk: fix link error for rcar-gen2"
applied to enable clk-rcar-gen2.o on R8A7745?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] clk: renesas: cpg_mstp: build for R8A774{3,5} Arnd Bergmann <arnd@arndb.de> - 2016-11-24 17:30 +0100
  Re: [PATCH] clk: renesas: cpg_mstp: build for R8A774{3,5} Geert Uytterhoeven <geert@linux-m68k.org> - 2016-11-24 17:40 +0100
    Re: [PATCH] clk: renesas: cpg_mstp: build for R8A774{3,5} Arnd Bergmann <arnd@arndb.de> - 2016-11-24 17:50 +0100

csiph-web