Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC
Date	2016-11-24 12:20 +0100
Message-ID	<sH0el-1UP-15@gated-at.bofh.it> (permalink)
References	<syiNb-1CZ-11@gated-at.bofh.it> <sGYYW-Vx-25@gated-at.bofh.it> <sGZUZ-1zn-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thursday, November 24, 2016 6:57:18 PM CET Ziji Hu wrote:
> > 
> > Please explain in the changelog why this is not a generic
> > phy driver (or three of them).
> > 
>         Actually we tried to put the PHY code into Linux PHY framework.
>         But it cannot fit in Linux common PHY framework.
> 
>         Our Xenon SDHC PHY register is a part of Xenon SDHC register set.
>         Besides, during MMC initialization, MMC sequence has to call several PHY functions to complete timing setting.
>         In those PHY setting functions, they have to access SDHC register and know current MMC setting, such as bus width, clock frequency and speed mode.
>         As a result, we have to implement PHY under MMC directory.
> 

Ok, that makes sense, just put the same text in the changelog comment.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC Arnd Bergmann <arnd@arndb.de> - 2016-11-24 11:00 +0100
  Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell  Xenon SDHC Ziji Hu <huziji@marvell.com> - 2016-11-24 12:00 +0100
    Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC Arnd Bergmann <arnd@arndb.de> - 2016-11-24 12:20 +0100

csiph-web