Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1529179

[PATCH 7/7] ovl: intercept fsync

Show all headers | View raw

Fsync is really an inode operation (AFAICS) so a doing it on a O_RDONLY
file descriptor should flush any data written through an O_WRONLY file
descriptor for example.

To make this work correctly in case the file is copied up after being
opened for read intercept the fsync fop, similarly to read_iter and mmap.

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
---
 fs/overlayfs/inode.c | 23 ++++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
index 25b31c6ebe9e..f522cb350f3c 100644
--- a/fs/overlayfs/inode.c
+++ b/fs/overlayfs/inode.c
@@ -412,6 +412,24 @@ static int ovl_mmap(struct file *file, struct vm_area_struct *vma)
 	return file->f_op->mmap(file, vma);
 }
 
+static int ovl_fsync(struct file *file, loff_t start, loff_t end, int datasync)
+{
+	int ret;
+
+	if (likely(ovl_file_is_lower(file))) {
+		return OVL_CALL_REAL_FOP(file,
+					 fsync(file, start, end, datasync));
+	}
+	file = filp_clone_open(file);
+	if (IS_ERR(file))
+		return PTR_ERR(file);
+
+	ret = vfs_fsync_range(file, start, end, datasync);
+	fput(file);
+
+	return ret;
+}
+
 static struct ovl_fops *ovl_fops_find(const struct file_operations *orig)
 {
 	struct ovl_fops *ofop;
@@ -453,9 +471,8 @@ static struct ovl_fops *ovl_fops_get(struct file *file)
 			ofop->fops.read_iter = ovl_read_iter;
 		if (orig->mmap)
 			ofop->fops.mmap = ovl_mmap;
-
-		/* These will need to be intercepted: */
-		ofop->fops.fsync = orig->fsync;
+		if (orig->fsync)
+			ofop->fops.fsync = ovl_fsync;
 
 		/*
 		 * These should be intercepted, but they are very unlikely to be
-- 
2.5.5

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] overlayfs: fix ro/rw fd data inconsistecies Miklos Szeredi <mszeredi@redhat.com> - 2016-11-24 12:00 +0100
  [PATCH 0/7] overlayfs: fix ro/rw fd data inconsistecies Miklos Szeredi <mszeredi@redhat.com> - 2016-11-24 12:00 +0100
    Re: [PATCH 0/7] overlayfs: fix ro/rw fd data inconsistecies Miklos Szeredi <miklos@szeredi.hu> - 2016-11-24 15:20 +0100
      Re: [PATCH 0/7] overlayfs: fix ro/rw fd data inconsistecies Amir Goldstein <amir73il@gmail.com> - 2016-11-24 22:00 +0100
  [PATCH 3/7] mm: ovl: copy-up on MAP_SHARED Miklos Szeredi <mszeredi@redhat.com> - 2016-11-24 12:00 +0100
  [PATCH 4/7] ovl: add infrastructure for intercepting file ops Miklos Szeredi <mszeredi@redhat.com> - 2016-11-24 12:00 +0100
    Re: [PATCH 4/7] ovl: add infrastructure for intercepting file ops Amir Goldstein <amir73il@gmail.com> - 2016-11-24 13:00 +0100
      Re: [PATCH 4/7] ovl: add infrastructure for intercepting file ops Miklos Szeredi <miklos@szeredi.hu> - 2016-11-24 13:10 +0100
        Re: [PATCH 4/7] ovl: add infrastructure for intercepting file ops Amir Goldstein <amir73il@gmail.com> - 2016-11-24 14:20 +0100
          Re: [PATCH 4/7] ovl: add infrastructure for intercepting file ops Miklos Szeredi <miklos@szeredi.hu> - 2016-11-24 15:00 +0100
            Re: [PATCH 4/7] ovl: add infrastructure for intercepting file ops Amir Goldstein <amir73il@gmail.com> - 2016-11-24 15:10 +0100
              Re: [PATCH 4/7] ovl: add infrastructure for intercepting file ops Amir Goldstein <amir73il@gmail.com> - 2016-11-25 06:30 +0100
  [PATCH 5/7] ovl: intercept read_iter Miklos Szeredi <mszeredi@redhat.com> - 2016-11-24 12:00 +0100
  [PATCH 1/7] vfs: allow overlayfs to intercept file ops Miklos Szeredi <mszeredi@redhat.com> - 2016-11-24 12:00 +0100
  [PATCH 6/7] ovl: intercept mmap Miklos Szeredi <mszeredi@redhat.com> - 2016-11-24 12:10 +0100
    Re: [PATCH 6/7] ovl: intercept mmap Amir Goldstein <amir73il@gmail.com> - 2016-11-24 14:30 +0100
      Re: [PATCH 6/7] ovl: intercept mmap Amir Goldstein <amir73il@gmail.com> - 2016-11-24 19:10 +0100
        Re: [PATCH 6/7] ovl: intercept mmap Amir Goldstein <amir73il@gmail.com> - 2016-11-24 20:10 +0100
  [PATCH 2/7] vfs: export filp_clone_open() Miklos Szeredi <mszeredi@redhat.com> - 2016-11-24 12:10 +0100
  [PATCH 7/7] ovl: intercept fsync Miklos Szeredi <mszeredi@redhat.com> - 2016-11-24 12:10 +0100

csiph-web