Re: [PATCH v6 1/5] USB: ohci: da8xx: use ohci priv data instead of globals

From	David Lechner <david@lechnology.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 1/5] USB: ohci: da8xx: use ohci priv data instead of globals
Date	2016-11-22 21:50 +0100
Message-ID	<sGqaR-3JU-13@gated-at.bofh.it> (permalink)
References	<sFZNn-3C2-5@gated-at.bofh.it> <sFZNn-3C2-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/21/2016 10:30 AM, Axel Haslam wrote:
> Instead of global variables, use the extra_priv_size of
> the ohci driver.
>
> We cannot yet move the ocic mask because this is used on
> the interrupt handler which is registerded through platform

s/registerded/registered/

> data and does not have an hcd pointer. This will be moved
> on a later patch.
>
> Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
> ---

Looks good to me (other than the spelling error above).

Tested-by: David Lechner <david@lechnology.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 1/5] USB: ohci: da8xx: use ohci priv data instead of globals Axel Haslam <ahaslam@baylibre.com> - 2016-11-21 17:40 +0100
  Re: [PATCH v6 1/5] USB: ohci: da8xx: use ohci priv data instead of  globals David Lechner <david@lechnology.com> - 2016-11-22 21:50 +0100

csiph-web