Re: [PATCH] proc: calculate /proc/* and /proc//task/ nlink at init time

From	Vegard Nossum <vegard.nossum@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] proc: calculate /proc/* and /proc//task/ nlink at init time
Date	2016-11-22 19:50 +0100
Message-ID	<sGoiK-2wz-31@gated-at.bofh.it> (permalink)
References	<sGnwl-1Wv-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 22 November 2016 at 20:55, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> Runtime nlink calculation works but meh. I don't know how to do it
> at compile time, but I know how to do it at init time.
>
> Shift "2+" part into init time as a bonus.

Couple of small suggestions:

- rename set_proc_pid_nlink() to proc_pid_nlink_init() to make it 100%
clear it's a one time thing

- move pid_entry_nlink() down to just above where it is called

Either way,

Acked-by/Reviewed-by: Vegard Nossum <vegard.nossum@oracle.com>


Vegard

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] proc: calculate /proc/* and /proc/*/task/* nlink at init time Alexey Dobriyan <adobriyan@gmail.com> - 2016-11-22 19:00 +0100
  Re: [PATCH] proc: calculate /proc/* and /proc/*/task/* nlink at init time Vegard Nossum <vegard.nossum@gmail.com> - 2016-11-22 19:50 +0100

csiph-web