Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1527749
| From | Rob Clark <robdclark@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function. |
| Date | 2016-11-22 18:40 +0100 |
| Message-ID | <sGncZ-1Py-1@gated-at.bofh.it> (permalink) |
| References | <sGmqC-1ia-23@gated-at.bofh.it> <sGmAm-1lo-13@gated-at.bofh.it> <sGn3j-1LJ-9@gated-at.bofh.it> <sGncZ-1Py-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Nov 22, 2016 at 12:31 PM, Ville Syrjälä
<ville.syrjala@linux.intel.com> wrote:
> On Tue, Nov 22, 2016 at 12:23:59PM -0500, Rob Clark wrote:
>> On Tue, Nov 22, 2016 at 11:50 AM, Ville Syrjälä
>> <ville.syrjala@linux.intel.com> wrote:
>> > On Tue, Nov 22, 2016 at 04:41:06PM +0000, Liviu Dudau wrote:
>> >> drm_get_format_name() de-references the buf parameter without checking
>> >> if the pointer was not NULL. Given that the function is EXPORT-ed, lets
>> >> sanitise the parameters before proceeding.
>> >>
>> >> Fixes: b3c11ac267d461d3d5 ("drm: move allocation out of drm_get_format_name())
>> >> Cc: Eric Engestrom <eric@engestrom.ch>
>> >> Cc: Rob Clark <robdclark@gmail.com>
>> >> Cc: Jani Nikula <jani.nikula@intel.com>
>> >> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> >>
>> >> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
>> >> ---
>> >> drivers/gpu/drm/drm_fourcc.c | 3 +++
>> >> 1 file changed, 3 insertions(+)
>> >>
>> >> diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c
>> >> index 90d2cc8..0a3ff0b 100644
>> >> --- a/drivers/gpu/drm/drm_fourcc.c
>> >> +++ b/drivers/gpu/drm/drm_fourcc.c
>> >> @@ -85,6 +85,9 @@ EXPORT_SYMBOL(drm_mode_legacy_fb_format);
>> >> */
>> >> const char *drm_get_format_name(uint32_t format, struct drm_format_name_buf *buf)
>> >> {
>> >> + if (!buf)
>> >> + return NULL;
>> >> +
>> >
>> > Seems rather pointless to me. Why would you ever pass NULL to this guy?
>>
>> perhaps BUG_ON(!buf)...
>
> And how does that differ from just buf->foo?
it gets you a file and line # in the error splat.. not that
drm_get_format_name() is such a big function that it would be
difficult to decipher the null deref crash, but if we added anything
it should be BUG_ON() to make it clear that passing null isn't a
caller error.
BR,
-R
>>
>> BR,
>> -R
>>
>> >> snprintf(buf->str, sizeof(buf->str),
>> >> "%c%c%c%c %s-endian (0x%08x)",
>> >> printable_char(format & 0xff),
>> >> --
>> >> 2.10.2
>> >>
>> >> _______________________________________________
>> >> dri-devel mailing list
>> >> dri-devel@lists.freedesktop.org
>> >> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>> >
>> > --
>> > Ville Syrjälä
>> > Intel OTC
>> > _______________________________________________
>> > dri-devel mailing list
>> > dri-devel@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Ville Syrjälä
> Intel OTC
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drm: check for NULL parameter in exported drm_get_format_name() function. Liviu Dudau <Liviu.Dudau@arm.com> - 2016-11-22 17:50 +0100
Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function. Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-11-22 18:00 +0100
Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function. Rob Clark <robdclark@gmail.com> - 2016-11-22 18:30 +0100
Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function. Rob Clark <robdclark@gmail.com> - 2016-11-22 18:40 +0100
Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function. Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-11-22 19:10 +0100
Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function. Sean Paul <seanpaul@chromium.org> - 2016-11-22 19:20 +0100
Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function. Liviu Dudau <Liviu.Dudau@arm.com> - 2016-11-22 20:20 +0100
Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function. Rob Clark <robdclark@gmail.com> - 2016-11-22 23:10 +0100
[PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function. Liviu Dudau <Liviu.Dudau@arm.com> - 2016-11-23 12:00 +0100
Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function. Jani Nikula <jani.nikula@intel.com> - 2016-11-23 12:10 +0100
Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function. Liviu Dudau <Liviu.Dudau@arm.com> - 2016-11-23 12:30 +0100
Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function. Daniel Vetter <daniel@ffwll.ch> - 2016-11-23 13:30 +0100
Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function. Jani Nikula <jani.nikula@intel.com> - 2016-11-23 13:50 +0100
Re: [PATCH v2] drm: check for NULL parameter in exported drm_get_format_name() function. Liviu Dudau <Liviu.Dudau@arm.com> - 2016-11-23 14:40 +0100
Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function. Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-11-22 18:40 +0100
Re: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function. Liviu Dudau <Liviu.Dudau@arm.com> - 2016-11-22 19:50 +0100
csiph-web