Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1527492

Re: [PATCH 3/3] ARM: davinci: hawk: use gpio descriptor for card detect

Show all headers | View raw

On Tue, Nov 22, 2016 at 11:26 AM, Sekhar Nori <nsekhar@ti.com> wrote:
> On Monday 21 November 2016 09:45 PM, Axel Haslam wrote:
>> Currently the mmc driver is polling the gpio to know if the
>> card was removed.
>>
>> By using a gpio descriptor instead of the platform callbacks, the
>> driver will be able to register the gpio with the mmc core with API's
>> designed for this purpose.
>>
>> This has the advantage that an irq will be registered,
>> and polling is no longer needed. Also, platform callbacks can be removed.
>>
>> Signed-off-by: Axel Haslam <ahaslam@baylibre.com>
>
> This patch looks good, provided it is not based of 1/3 and 2/3. There
> are other boards in mach-davinci using the card detect and wp callbacks.
> And some like board-dm365-evm.c have those pins routed through a CPLD.
> So I guess there is more work to be done before platform callbacks can
> completely be removed from MMC/SD driver. But the closer we get, the
> better it is :)
>

Yes, i saw the platform using CPLD for the pins. that might be tricky to remove.
we can flag the mmc "broken card detect" which would force polling on the pin.
im not sure if it is feasible to move the cpld pin handling to a
driver.. (maybe a
gpio driver?)


> Thanks,
> Sekhar
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] ARM: davinci: hawk: fix mmc gpio declaration Axel Haslam <ahaslam@baylibre.com> - 2016-11-21 17:20 +0100
  [PATCH 2/3] ARM: davinci: hawk: remove mmc ro pin Axel Haslam <ahaslam@baylibre.com> - 2016-11-21 17:20 +0100
    Re: [PATCH 2/3] ARM: davinci: hawk: remove mmc ro pin Sekhar Nori <nsekhar@ti.com> - 2016-11-22 11:00 +0100
  [PATCH 1/3] ARM: davinci: hawk: fix mmc card detect gpio Axel Haslam <ahaslam@baylibre.com> - 2016-11-21 17:30 +0100
    Re: [PATCH 1/3] ARM: davinci: hawk: fix mmc card detect gpio Sekhar Nori <nsekhar@ti.com> - 2016-11-22 11:00 +0100
      Re: [PATCH 1/3] ARM: davinci: hawk: fix mmc card detect gpio Axel Haslam <ahaslam@baylibre.com> - 2016-11-22 11:20 +0100
        Re: [PATCH 1/3] ARM: davinci: hawk: fix mmc card detect gpio Sekhar Nori <nsekhar@ti.com> - 2016-11-22 11:30 +0100
  [PATCH 3/3] ARM: davinci: hawk: use gpio descriptor for card detect Axel Haslam <ahaslam@baylibre.com> - 2016-11-21 17:30 +0100
    Re: [PATCH 3/3] ARM: davinci: hawk: use gpio descriptor for card  detect Sekhar Nori <nsekhar@ti.com> - 2016-11-22 11:30 +0100
      Re: [PATCH 3/3] ARM: davinci: hawk: use gpio descriptor for card detect Axel Haslam <ahaslam@baylibre.com> - 2016-11-22 14:00 +0100

csiph-web