Re: [PATCH] ARM: ux500: fix prcmu_is_cpu_in_wfi() calculation

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: ux500: fix prcmu_is_cpu_in_wfi() calculation
Date	2016-11-22 10:10 +0100
Message-ID	<sGffs-5aZ-29@gated-at.bofh.it> (permalink)
References	<sEajU-4Eo-37@gated-at.bofh.it> <sGeW6-4Pc-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tuesday, November 22, 2016 9:47:20 AM CET Linus Walleij wrote:
> On Wed, Nov 16, 2016 at 4:20 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> 
> > This function clearly never worked and always returns true,
> > as pointed out by gcc-7:
> >
> > arch/arm/mach-ux500/pm.c: In function 'prcmu_is_cpu_in_wfi':
> > arch/arm/mach-ux500/pm.c:137:212: error: ?: using integer constants in boolean context, the expression will always evaluate to 'true' [-Werror=int-in-bool-context]
> >
> > With the added braces, the condition actually makes sense.
> >
> > Fixes: 34fe6f107eab ("mfd : Check if the other db8500 core is in WFI")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Will you apply it directly to ARM SoC or should I queue it and
> send it with a pull request?

I'd prefer you to queue and track it, thanks,

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ARM: ux500: fix prcmu_is_cpu_in_wfi() calculation Arnd Bergmann <arnd@arndb.de> - 2016-11-16 16:30 +0100
  Re: [PATCH] ARM: ux500: fix prcmu_is_cpu_in_wfi() calculation Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-11-16 16:40 +0100
  Re: [PATCH] ARM: ux500: fix prcmu_is_cpu_in_wfi() calculation Linus Walleij <linus.walleij@linaro.org> - 2016-11-22 09:50 +0100
    Re: [PATCH] ARM: ux500: fix prcmu_is_cpu_in_wfi() calculation Arnd Bergmann <arnd@arndb.de> - 2016-11-22 10:10 +0100

csiph-web