Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1527253

Re: [mm PATCH v3 21/23] mm: Add support for releasing multiple instances of a page

Show all headers | View raw

On Mon, 21 Nov 2016 08:21:39 -0800 Alexander Duyck <alexander.duyck@gmail.com> wrote:

> >> +                     __free_pages_ok(page, order);
> >> +     }
> >> +}
> >> +EXPORT_SYMBOL(__page_frag_drain);
> >
> > It's an exported-to-modules library function.  It should be documented,
> > please?  The page-frag API is only partially documented, but that's no
> > excuse.
> 
> Okay.  I assume you want the documentation as a follow-up patch since
> I received a notice that the patch was added to -mm?

Yes please.  Or a replacement patch which I'll temporarily turn into a
delta, either is fine.

> If you would like I could look at doing a couple of renaming patches
> so that we make the API a bit more consistent.  I could move the
> __alloc and __free to what you have suggested, and then take a look at
> trying to rename the refill/drain to be a bit more consistent in terms
> of what they are supposed to work on and how they are supposed to be
> used.

I think that would be better - it's hardly high-priority but a bit of
attention to the documentation and naming conventions would help tidy
things up.  When you can't find anything else to do ;)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [mm PATCH v3 21/23] mm: Add support for releasing multiple  instances of a page Andrew Morton <akpm@linux-foundation.org> - 2016-11-19 00:30 +0100
  Re: [mm PATCH v3 21/23] mm: Add support for releasing multiple  instances of a page Alexander Duyck <alexander.duyck@gmail.com> - 2016-11-21 17:30 +0100
    Re: [mm PATCH v3 21/23] mm: Add support for releasing multiple  instances of a page Andrew Morton <akpm@linux-foundation.org> - 2016-11-22 07:30 +0100

csiph-web