Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1527202

Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

Show all headers | View raw

On Tue, Nov 22, 2016 at 10:33:27AM +0800, Caesar Wang wrote:
> 在 2016年11月22日 10:15, Brian Norris 写道:
> >On Tue, Nov 22, 2016 at 09:51:23AM +0800, Caesar Wang wrote:
> >>CHECK: Alignment should match open parenthesis
> >>#428: FILE: drivers/thermal/rockchip_thermal.c:428:
> >>+    pr_err("%s: invalid temperature, temp=%d error=%d\n",
> >>+        __func__, temp, error);
> >>
> >>CHECK: Alignment should match open parenthesis
> >>#480: FILE: drivers/thermal/rockchip_thermal.c:480:
> >>+        pr_err("%s: invalid conversion table, mode=%d\n",
> >>+            __func__, table->mode);
> >What patch are you checking? I ran mine through checkpatch, and there
> >are no problems.
> 
> That  just checkcode on Chromeos kernelv4.4,  that trivial things :)
> $chromiumos/src/third_party/kernel/v4.4$ checkcode

I'm not familiar with that tool, and that repository isn't upstream
but...

> drivers/thermal/rockchip_thermal.c
> CHECK: Alignment should match open parenthesis
> #428: FILE: drivers/thermal/rockchip_thermal.c:428:
> +    pr_err("%s: invalid temperature, temp=%d error=%d\n",
> +        __func__, temp, error);

...on approximately my 10th read of this...I guess maybe this tool has
determined that 2 tabs is 1 character too much, because the second line
lines up with the '%' instead of the '"'. If this is so important to
you, you can of course edit my patch and include it with yours.

Regards,
Brian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] thermal: handle get_temp() errors properly Brian Norris <briannorris@chromium.org> - 2016-11-19 01:00 +0100
  [PATCH 2/3] thermal: rockchip: improve conversion error messages Brian Norris <briannorris@chromium.org> - 2016-11-19 01:00 +0100
    Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages Caesar Wang <wxt@rock-chips.com> - 2016-11-19 05:00 +0100
    Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages Caesar Wang <wxt@rock-chips.com> - 2016-11-19 05:00 +0100
      Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages Caesar Wang <caesar.upstream@gmail.com> - 2016-11-22 03:00 +0100
        Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages Brian Norris <briannorris@chromium.org> - 2016-11-22 03:20 +0100
          Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages Caesar Wang <caesar.upstream@gmail.com> - 2016-11-22 03:40 +0100
            Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages Brian Norris <briannorris@chromium.org> - 2016-11-22 04:50 +0100
        Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages Zhang Rui <rui.zhang@intel.com> - 2016-11-22 09:00 +0100
          Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages Caesar Wang <caesar.upstream@gmail.com> - 2016-11-22 13:50 +0100
  Re: [PATCH 1/3] thermal: handle get_temp() errors properly Caesar Wang <sasukewxt@163.com> - 2016-11-19 04:30 +0100
  Re: [PATCH 1/3] thermal: handle get_temp() errors properly Eduardo Valentin <edubezval@gmail.com> - 2016-11-19 04:50 +0100
    Re: [PATCH 1/3] thermal: handle get_temp() errors properly Brian Norris <briannorris@chromium.org> - 2016-11-19 06:40 +0100
      Re: [PATCH 1/3] thermal: handle get_temp() errors properly Zhang Rui <rui.zhang@intel.com> - 2016-11-22 09:00 +0100
        Re: [PATCH 1/3] thermal: handle get_temp() errors properly Eduardo Valentin <edubezval@gmail.com> - 2016-11-22 12:10 +0100
          Re: [PATCH 1/3] thermal: handle get_temp() errors properly Brian Norris <briannorris@chromium.org> - 2016-11-22 23:40 +0100

csiph-web