Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1529103
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] usb: xhci: Remove unuseful 'return' statement |
| Date | 2016-11-24 10:40 +0100 |
| Message-ID | <sGYFA-Ou-23@gated-at.bofh.it> (permalink) |
| References | <sGXq9-92-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hello.
On 11/24/2016 11:13 AM, Baolin Wang wrote:
> Since these 'return' statements are not generally useful in void function,
> remove them.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
[...]
> diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
> index 48a26d378..d6f59a3 100644
> --- a/drivers/usb/host/xhci-mem.c
> +++ b/drivers/usb/host/xhci-mem.c
> @@ -1146,7 +1146,6 @@ int xhci_setup_addressable_virt_dev(struct xhci_hcd *xhci, struct usb_device *ud
> case USB_SPEED_WIRELESS:
> xhci_dbg(xhci, "FIXME xHCI doesn't support wireless speeds\n");
> return -EINVAL;
> - break;
Here you're removing *break* instead but not mentioning this in the patch
description...
[...]
MBR, Sergei
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] usb: xhci: Remove unuseful 'return' statement Baolin Wang <baolin.wang@linaro.org> - 2016-11-24 09:20 +0100
Re: [PATCH] usb: xhci: Remove unuseful 'return' statement Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-11-24 10:40 +0100
Re: [PATCH] usb: xhci: Remove unuseful 'return' statement Baolin Wang <baolin.wang@linaro.org> - 2016-11-24 12:00 +0100
csiph-web