Re: [PATCH 1/2] gpio: axp209: use correct register for GPIO input status

From	Chen-Yu Tsai <wens@csie.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] gpio: axp209: use correct register for GPIO input status
Date	2016-11-24 07:00 +0100
Message-ID	<sGVeF-6OY-5@gated-at.bofh.it> (permalink)
References	<sGFWi-5vy-25@gated-at.bofh.it> <sGFWi-5vy-33@gated-at.bofh.it> <sGG5X-5zw-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Nov 23, 2016 at 9:45 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Wed, 23 Nov 2016 14:27:48 +0100, Quentin Schulz wrote:
>> The GPIO input status was read from control register
>> (AXP20X_GPIO[210]_CTRL) instead of status register (AXP20X_GPIO20_SS).
>>
>> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
>
> This smells like a bug fix, so perhaps Cc: stable?

Presently there are no in-tree boards that use the GPIOs
as input. And the only user I see is the CHIP, for the headphone
jack detection. Again, not supported in mainline yet.

Not sure if there is value in sending it for stable.

ChenYu

>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] add support for AXP209 GPIOs functions Quentin Schulz <quentin.schulz@free-electrons.com> - 2016-11-23 14:40 +0100
  [PATCH 1/2] gpio: axp209: use correct register for GPIO input status Quentin Schulz <quentin.schulz@free-electrons.com> - 2016-11-23 14:40 +0100
    Re: [PATCH 1/2] gpio: axp209: use correct register for GPIO input  status Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-11-23 14:50 +0100
      Re: [PATCH 1/2] gpio: axp209: use correct register for GPIO input status Chen-Yu Tsai <wens@csie.org> - 2016-11-24 07:00 +0100

csiph-web