Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1528825
| Path | csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Bjorn Helgaas <helgaas@kernel.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] PCI Hotplug: cpqphp: Add missing call to pci_disable_device |
| Date | Thu, 24 Nov 2016 00:00:01 +0100 |
| Message-ID | <sGOGd-2vZ-5@gated-at.bofh.it> (permalink) |
| References | <sFhW1-7Z6-25@gated-at.bofh.it> |
| X-Original-To | Quentin Lambert <lambert.quentin@gmail.com> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.21 (2010-09-15) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 31 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org |
| X-Original-Date | Wed, 23 Nov 2016 16:58:51 -0600 |
| X-Original-Message-ID | <20161123225851.GJ16033@bhelgaas-glaptop.roam.corp.google.com> |
| X-Original-References | <20161119174148.20187-1-lambert.quentin@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1528825 |
Show key headers only | View raw
On Sat, Nov 19, 2016 at 06:41:48PM +0100, Quentin Lambert wrote:
> Most error branches following the call to pci_enable_device contain
> a call to pci_disable_device. This patch add these calls where they are
> missing.
>
> This issue was found with Hector.
>
> Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Applied to pci/hotplug for v4.10, thanks, Quentin!
> ---
> drivers/pci/hotplug/cpqphp_core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- a/drivers/pci/hotplug/cpqphp_core.c
> +++ b/drivers/pci/hotplug/cpqphp_core.c
> @@ -867,7 +867,8 @@ static int cpqhpc_probe(struct pci_dev *
> */
> if ((pdev->revision <= 2) && (vendor_id != PCI_VENDOR_ID_INTEL)) {
> err(msg_HPC_not_supported);
> - return -ENODEV;
> + rc = -ENODEV;
> + goto err_disable_device;
> }
>
> /* TODO: This code can be made to support non-Compaq or Intel
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] PCI Hotplug: cpqphp: Add missing call to pci_disable_device Quentin Lambert <lambert.quentin@gmail.com> - 2016-11-19 18:50 +0100 Re: [PATCH] PCI Hotplug: cpqphp: Add missing call to pci_disable_device Bjorn Helgaas <helgaas@kernel.org> - 2016-11-24 00:00 +0100
csiph-web