Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1528699

Re: [patch 0/5] powercap/intel_rapl: Fixes, hotplug conversion and simplifcation

Show all headers | View raw

On Tue, 22 Nov 2016 21:15:56 -0000
Thomas Gleixner <tglx@linutronix.de> wrote:

> The driver fails to:
> 
>  - initialize packages which are not available at driver init time,
> though the value of that initialization is completely unclear as
> nothing ever uses these values. I fixed it up nevertheless and leave
> it to the maintainers to decide whether it should completely go away.
> 
>  - to propagate error codes in the hotplug online path, where a
>    registration fails and the package data is freed, but return code
> is 0.
> 
> The initialization/removal code of that driver is a maze of
> duplicated code which is more or less the same as the cpu hotplug
> code. After switching over the driver to the hotplug statemachine,
> the whole init/removal machinery can be replaced by
> installing/removing the hotplug state.
> 
> The total damage is:
> 
>  intel_rapl.c |  363
> ++++++++++++++++------------------------------------------- 1 file
> changed, 104 insertions(+), 259 deletions(-)
> 
> and the binary size shrinks as well:
> 
>    text	   data	    bss	    dec	    hex
>    7996	    625	     32	   8653
> 21cd	  Before 7216	    593	     32
> 7841	   1ea1	  After
> 
I have successfully tested this patchset with various cpu online/offline
scenarios on both single and dual socket systems.

Looks good to me. The cpu topology management is much more streamlined.
Thanks. I also sent out this patch below on top of yours.

[PATCH] powercap/intel_rapl: fix and tidy up error handling

Thanks,

Jacob
> Thanks,
> 
> 	tglx
> 
> 
> 
> 

[Jacob Pan]

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch 0/5] powercap/intel_rapl: Fixes,  hotplug conversion and simplifcation Thomas Gleixner <tglx@linutronix.de> - 2016-11-22 22:20 +0100
  [patch 5/5] powercap/intel_rapl: Track active CPUs internally Thomas Gleixner <tglx@linutronix.de> - 2016-11-22 22:20 +0100
  [patch 2/5] powercap/intel_rapl: Propagate error code when  registration fails Thomas Gleixner <tglx@linutronix.de> - 2016-11-22 22:20 +0100
  [patch 3/5] powercap/intel rapl: Convert to hotplug state machine Thomas Gleixner <tglx@linutronix.de> - 2016-11-22 22:20 +0100
  [patch 4/5] powercap/intel_rapl: Cleanup duplicated init code Thomas Gleixner <tglx@linutronix.de> - 2016-11-22 22:20 +0100
  [patch 1/5] powercap/intel_rapl: Add missing domain data update on  hotplug Thomas Gleixner <tglx@linutronix.de> - 2016-11-22 22:30 +0100
    Re: [patch 1/5] powercap/intel_rapl: Add missing domain data update  on hotplug Jacob Pan <jacob.jun.pan@linux.intel.com> - 2016-11-23 02:30 +0100
  Re: [patch 0/5] powercap/intel_rapl: Fixes, hotplug conversion and  simplifcation Jacob Pan <jacob.jun.pan@linux.intel.com> - 2016-11-23 20:10 +0100
    Re: [patch 0/5] powercap/intel_rapl: Fixes, hotplug conversion and simplifcation "Rafael J. Wysocki" <rafael@kernel.org> - 2016-11-23 22:20 +0100
      Re: [patch 0/5] powercap/intel_rapl: Fixes, hotplug conversion and  simplifcation Thomas Gleixner <tglx@linutronix.de> - 2016-11-24 09:40 +0100
        Re: [patch 0/5] powercap/intel_rapl: Fixes, hotplug conversion and simplifcation "Rafael J. Wysocki" <rafael@kernel.org> - 2016-11-24 22:10 +0100

csiph-web