Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1528535

Re: [PATCH v2 0/6] staging: speakup: speakup_soft.c checkpatch modifications

Show all headers | View raw

On Wed, Nov 23, 2016 at 05:52:25AM -0500, Fleetwood Farm wrote:
> On Nov 23, 2016 4:08 AM, "Greg KH" <gregkh@linuxfoundation.org> wrote:
> >
> > On Mon, Nov 21, 2016 at 10:19:19AM -0500, Walt Feasel wrote:
> > > Make Linux kernel style modifications for speak_soft.c to include:
> > >
> > > Space around operator
> > > Logical continuation
> > > Multiple blank lines
> > > Blank line after {
> > > comment modifications
> > > Align parenthesis
> >
> > Ok, now that you have a bunch of cleanup patches accepted, why not work
> > on some "real" code changes?  There's no need to fix all of the coding
> > style issues in drivers/staging/ at once, leave some for other people to
> > learn on :)
> >
> > thanks,
> >
> > greg k-h
> 
> Well, I have around 40 more patches already prepared waiting for my limit to
> clear (which just did) and about 12 more files left to checkpatch in speakup.
> I am currently waiting on the newbies administer to clear my sent emails asking
> advice on if some of my tougher challenges (octals and CamelCase) are done
> correctly.

"newbies administrator"?

> I am also currently waiting on the u-boot mailing list administer to do the
> same on some of my patches.
> I also am doing some online 'c' courses to increase (get) my skills set.
> What type of "real" code changes did you have in mind with my limited skill
> set?

I'd strongly suggest working on some userspace programs to get a
less-limited skill set :)  Then find some area of the kernel you are
interested in, and help out there.  Speakup really can use the help, and
the community of users of their devices is very good, so any real work
you can do there would always be greatly appreciated.

best of luck,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/6] staging: speakup: speakup_soft.c checkpatch modifications Walt Feasel <waltfeasel@gmail.com> - 2016-11-21 16:20 +0100
  [PATCH v2 6/6] staging: speakup: speakup_soft.c Align parenthesis Walt Feasel <waltfeasel@gmail.com> - 2016-11-21 16:30 +0100
  [PATCH v2 5/6] staging: speakup: speakup_soft.c comment modifications Walt Feasel <waltfeasel@gmail.com> - 2016-11-21 16:30 +0100
  [PATCH v2 3/6] staging: speakup: speakup_soft.c Multiple blank lines Walt Feasel <waltfeasel@gmail.com> - 2016-11-21 16:30 +0100
  [PATCH v2 4/6] staging: speakup: speakup_soft.c Blank line after { Walt Feasel <waltfeasel@gmail.com> - 2016-11-21 16:30 +0100
  [PATCH v2 2/6] staging: speakup: speakup_soft.c Logical continuation Walt Feasel <waltfeasel@gmail.com> - 2016-11-21 16:30 +0100
  [PATCH v2 1/6] staging: speakup: speakup_soft.c Space around operator Walt Feasel <waltfeasel@gmail.com> - 2016-11-21 16:30 +0100
  Re: [PATCH v2 0/6] staging: speakup: speakup_soft.c checkpatch  modifications Greg KH <gregkh@linuxfoundation.org> - 2016-11-23 10:10 +0100
    Re: [PATCH v2 0/6] staging: speakup: speakup_soft.c checkpatch  modifications Greg KH <gregkh@linuxfoundation.org> - 2016-11-23 17:00 +0100
      Re: [PATCH v2 0/6] staging: speakup: speakup_soft.c checkpatch  modifications Walt Feasel <waltfeasel@gmail.com> - 2016-11-23 17:30 +0100

csiph-web