Re: [PATCH 1/2] of: base: add support to get machine model name

From	Sudeep Holla <sudeep.holla@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] of: base: add support to get machine model name
Date	2016-11-23 11:40 +0100
Message-ID	<sGD85-3GY-19@gated-at.bofh.it> (permalink)
References	<sEzih-48J-11@gated-at.bofh.it> <sESEi-8qT-31@gated-at.bofh.it> <sEXDY-3lW-11@gated-at.bofh.it> <sGoiK-2wz-29@gated-at.bofh.it> <sGqXg-4ft-19@gated-at.bofh.it>
Organization	ARM

Show all headers | View raw


On 22/11/16 21:35, Rob Herring wrote:
> On Tue, Nov 22, 2016 at 12:44 PM, Frank Rowand <frowand.list@gmail.com> wrote:

[...]

>>
>> This patch adds a function that leads to conflating the "model" property
>> and the "compatible" property. This leads to opaque, confusing and unclear
>> code where ever it is used.   I think it is not good for the device tree
>> framework to contribute to writing unclear code.
>>
>> Further, only two of the proposed users of this new function appear to
>> be proper usage.  I do not think that the small amount of reduced lines
>> of code is a good trade off for the reduced code clarity and for the
>> potential for future mis-use of this function.
>>
>> Can I convince you to revert this patch?
>
> Yes, I will revert.
>
>> If not, will you accept a patch to change the function name to more
>> clearly indicate what it does?  (One possible name would be
>> of_model_or_1st_compatible().)
>
> I took it as there's already the FDT equivalent function.

Yes it was mainly for non of_flat_* replacement for
of_flat_dt_get_machine_name

-- 
Regards,
Sudeep

Thread

[PATCH 1/2] of: base: add support to get machine model name Sudeep Holla <sudeep.holla@arm.com> - 2016-11-17 19:10 +0100
  Re: [PATCH 1/2] of: base: add support to get machine model name Frank Rowand <frowand.list@gmail.com> - 2016-11-17 22:10 +0100
    Re: [PATCH 1/2] of: base: add support to get machine model name Frank Rowand <frowand.list@gmail.com> - 2016-11-17 23:20 +0100
    Re: [PATCH 1/2] of: base: add support to get machine model name Sudeep Holla <sudeep.holla@arm.com> - 2016-11-18 11:50 +0100
      Re: [PATCH 1/2] of: base: add support to get machine model name Frank Rowand <frowand.list@gmail.com> - 2016-11-18 21:30 +0100
        Re: [PATCH 1/2] of: base: add support to get machine model name Frank Rowand <frowand.list@gmail.com> - 2016-11-21 17:10 +0100
          Re: [PATCH 1/2] of: base: add support to get machine model name Sudeep Holla <sudeep.holla@arm.com> - 2016-11-21 17:30 +0100
            Re: [PATCH 1/2] of: base: add support to get machine model name Frank Rowand <frowand.list@gmail.com> - 2016-11-21 20:30 +0100
              Re: [PATCH 1/2] of: base: add support to get machine model name Frank Rowand <frowand.list@gmail.com> - 2016-11-21 22:00 +0100
        Re: [PATCH 1/2] of: base: add support to get machine model name Sudeep Holla <sudeep.holla@arm.com> - 2016-11-21 17:30 +0100
          Re: [PATCH 1/2] of: base: add support to get machine model name Frank Rowand <frowand.list@gmail.com> - 2016-11-21 21:30 +0100
  Re: [PATCH 1/2] of: base: add support to get machine model name Rob Herring <robh@kernel.org> - 2016-11-18 15:50 +0100
    Re: [PATCH 1/2] of: base: add support to get machine model name Frank Rowand <frowand.list@gmail.com> - 2016-11-18 21:10 +0100
      Re: [PATCH 1/2] of: base: add support to get machine model name Frank Rowand <frowand.list@gmail.com> - 2016-11-22 19:50 +0100
        Re: [PATCH 1/2] of: base: add support to get machine model name Rob Herring <robh@kernel.org> - 2016-11-22 22:40 +0100
          Re: [PATCH 1/2] of: base: add support to get machine model name Sudeep Holla <sudeep.holla@arm.com> - 2016-11-23 11:40 +0100
        Re: [PATCH 1/2] of: base: add support to get machine model name Sudeep Holla <sudeep.holla@arm.com> - 2016-11-23 11:40 +0100

csiph-web