Re: [PATCH v6 2/2] Input: synaptics-rmi4 - add support for F34 V7 bootloader

From	Nick Dyer <nick@shmanahar.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 2/2] Input: synaptics-rmi4 - add support for F34 V7 bootloader
Date	2016-11-23 11:00 +0100
Message-ID	<sGCvn-3a3-3@gated-at.bofh.it> (permalink)
References	<sFFEZ-7xw-7@gated-at.bofh.it> <sFFEZ-7xw-13@gated-at.bofh.it> <sGv0R-6Id-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Nov 22, 2016 at 05:51:11PM -0800, Dmitry Torokhov wrote:
> On Sun, Nov 20, 2016 at 07:04:02PM +0000, Nick Dyer wrote:
> > +			/* query 7 */
> > +			unsigned char f34_query7_b0:1;
> > +			unsigned char has_bootloader:1;
> > +			unsigned char has_device_config:1;
> > +			unsigned char has_flash_config:1;
> > +			unsigned char has_manufacturing_block:1;
> > +			unsigned char has_guest_serialization:1;
> > +			unsigned char has_global_parameters:1;
> > +			unsigned char has_core_code:1;
> > +			unsigned char has_core_config:1;
> > +			unsigned char has_guest_code:1;
> > +			unsigned char has_display_config:1;
> > +			unsigned char f34_query7_b11__15:5;
> > +			unsigned char f34_query7_b16__23;
> > +			unsigned char f34_query7_b24__31;
> 
> I see bitfields and I think this is not going to work on big endian
> arches because unfortunately they "fill" the bytes with bits in opposite
> order.
> 
> We had to rework old Unixsphere code to get rid of bitfields for on-wire
> data; this seems to be coming from that code base as well and so needs
> to be reworked too.

Hi Dmitry-

Thanks - that makes sense. I will rework this bit to remove the
bitfields.

cheers

Nick

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/2] Input: synaptics-rmi4 - F34 device reflash support Nick Dyer <nick@shmanahar.org> - 2016-11-20 20:10 +0100
  [PATCH v6 1/2] Input: synaptics-rmi4 - add support for F34 device reflash Nick Dyer <nick@shmanahar.org> - 2016-11-20 20:10 +0100
    Re: [PATCH v6 1/2] Input: synaptics-rmi4 - add support for F34  device reflash Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-11-23 03:00 +0100
    Re: [PATCH v6 1/2] Input: synaptics-rmi4 - add support for F34  device reflash Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-11-23 12:30 +0100
      Re: [PATCH v6 1/2] Input: synaptics-rmi4 - add support for F34  device reflash Nick Dyer <nick@shmanahar.org> - 2016-11-23 12:40 +0100
        Re: [PATCH v6 1/2] Input: synaptics-rmi4 - add support for F34  device reflash Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-11-23 13:50 +0100
  Re: [PATCH v6 2/2] Input: synaptics-rmi4 - add support for F34 V7  bootloader Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-11-23 03:00 +0100
    Re: [PATCH v6 2/2] Input: synaptics-rmi4 - add support for F34 V7  bootloader Nick Dyer <nick@shmanahar.org> - 2016-11-23 11:00 +0100

csiph-web